Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working on Error States for Images #97

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

duner
Copy link
Contributor

@duner duner commented Sep 20, 2016

Handles error states for images to fix #33.

@duner duner changed the title Working on Error States for Images [Not Ready to Merge] Working on Error States for Images Oct 18, 2016
@duner
Copy link
Contributor Author

duner commented Oct 18, 2016

@scott2b, can you review this?

@scott2b
Copy link
Member

scott2b commented Oct 18, 2016

@duner Is there a dependency that defines checkIfImage? you are calling it here but i don't see where it is defined

@JoeGermuska
Copy link
Member

Having let this sit for a year and then letting @duner graduate, I'm not optimistic that this is going to get its conflicts sorted out and finished as is... but maybe Alex is feeling nostalgic?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recognize bad image URL in authoring tool and give clearer feedback
3 participants