Hint the compiler that capacity is non-zero in mask_modulo #115
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #114. They are not compatible, sadly.
Modulo is faster for a non-zero divisor, so we can use the
NonZeroUsize
type to hint to the compiler that it can omit the case where the capacity is0
. However, we can only do that in non-const
context, so we need separate functions for theConstGenericRingBuffer
andAllocRingBuffer
. Which led me to implement it like this:This theoretically should only impact
AllocRingBuffer
for non powers of two. Theconst_mask_modulo
should compile to the same assembly as before, but who knows what the compiler might do. The benchmarks are a bit too noisy to tell.The improvements for alloc non power of two are significant, but less significant than #114: it ranges from -10% to -30%. @jonay2000's more consistent benchmarks might help to determine the actual difference.
I'll leave it up to you what direction you want to go between this and #114 in (if any).