Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding str() function to generators and operators #283

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Conversation

luitjens
Copy link
Collaborator

@luitjens luitjens commented Oct 6, 2022

No description provided.

@luitjens luitjens force-pushed the getstring branch 3 times, most recently from 87913f2 to d162951 Compare October 10, 2022 13:28
Copy link
Collaborator

@cliffburdick cliffburdick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's probably too late now, but if we make every variable constexpr static char* we can still construct the strings with std:: string, but it makes it possible to do compile-time generation later.

@luitjens
Copy link
Collaborator Author

it's probably too late now, but if we make every variable constexpr static char* we can still construct the strings with std:: string, but it makes it possible to do compile-time generation later.

I first started with compile time but due to limitations with std::string I couldn't get it to work. We can always revisit later. Right now I think trying to get it to be compile time would be more hassle than it is worth. This has zero impact on production runs as getstring won't be called. It likely has very minimal impact on profiling runs.

@luitjens luitjens merged commit 808465f into main Oct 11, 2022
@luitjens luitjens deleted the getstring branch November 10, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants