Workaround for maybe_unused parse bug in old gcc #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Versions of gcc prior to 9.3 have a bug parsing [[maybe_unused]] when applied to the first argument in a constructor: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81429 Although we do not officially support gcc versions prior to 9.3, this is a workaround for a couple such cases. Also, switch from CMake COPY_FILE to COPY to maintain compatability with CMake 3.20 (COPY_FILE was added in 3.21)
tbensonatl
requested review from
luitjens,
cliffburdick,
tmartin-gh and
tylera-nvidia
|
/blossom-ci |
cliffburdick
approved these changes
Nov 28, 2023
cliffburdick
pushed a commit
that referenced
this pull request
Dec 8, 2023
Versions of gcc prior to 9.3 have a bug parsing [[maybe_unused]] when applied to the first argument in a constructor: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81429 Although we do not officially support gcc versions prior to 9.3, this is a workaround for a couple such cases. Also, switch from CMake COPY_FILE to COPY to maintain compatability with CMake 3.20 (COPY_FILE was added in 3.21)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Versions of gcc prior to 9.3 have a bug parsing [[maybe_unused]] when applied to the first argument in a constructor:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81429
Although we do not officially support gcc versions prior to 9.3, this is a workaround for a couple such cases.
Also, switch from CMake COPY_FILE to COPY to maintain compatability with CMake 3.20 (COPY_FILE was added in 3.21)