Fix nans in QR and SVD. #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cliffburdick
approved these changes
Jan 11, 2024
luitjens
force-pushed
the
svd-qr-fixes
branch
from
19141e6
to
d319b7e
Compare
Fixes #543 Previously QR and SVD could devide by zero in some situations. New version avoids those divisions eliminating the nans. Also reworked workspace APIs to make interface easier to use.
luitjens
force-pushed
the
svd-qr-fixes
branch
from
d319b7e
to
c3910f7
Compare
|
/blossom-ci |
1 similar comment
|
/blossom-ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #543
Previously QR and SVD could devide by zero in some situations. New version avoids those divisions eliminating the nans.
Also reworked workspace APIs to make interface easier to use.