Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change check on build type to avoid short circuiting #647

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Change check on build type to avoid short circuiting #647

merged 1 commit into from
Jun 7, 2024

Conversation

cliffburdick
Copy link
Collaborator

@cliffburdick cliffburdick commented Jun 7, 2024 •
edited
Loading

Fixes #646

@cliffburdick
Copy link
Collaborator Author

/blossom-ci

@raplonu
Copy link
Contributor

raplonu commented Jun 7, 2024

@cliffburdick thanks for looking at this issue.

Another solution could be do the following:

if (NOT CMAKE_BUILD_TYPE OR "${CMAKE_BUILD_TYPE}" STREQUAL "Debug")

"${CMAKE_BUILD_TYPE}" will still be considered as a STRING even if empty.

@cliffburdick
Copy link
Collaborator Author

/blossom-ci

5 similar comments
@cliffburdick
Copy link
Collaborator Author

/blossom-ci

@cliffburdick
Copy link
Collaborator Author

/blossom-ci

@cliffburdick
Copy link
Collaborator Author

/blossom-ci

@cliffburdick
Copy link
Collaborator Author

/blossom-ci

@cliffburdick
Copy link
Collaborator Author

/blossom-ci

@coveralls
Copy link

Coverage Status

coverage: 93.603%. remained the same
when pulling 05db76c on ninja_cmake
into 1816b44 on main.

@cliffburdick cliffburdick merged commit e8f96bf into main Jun 7, 2024
1 check passed
@cliffburdick
Copy link
Collaborator Author

/blossom-ci

@cliffburdick cliffburdick deleted the ninja_cmake branch June 7, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Configuration error using Ninja Multi-Config.
3 participants
@cliffburdick @raplonu @coveralls