Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Japanese support for get_word_splitter #320

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Japanese support for get_word_splitter #320

wants to merge 3 commits into from

Conversation

sarahyurick
Copy link
Collaborator

Closes #257.

@sarahyurick
add japanese lang to get_word_splitter
81d8fec 
Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>
@sarahyurick
run black
72c444b 
Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>
ryantwolf
ryantwolf requested changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@ryantwolf ryantwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With documentation updates, this should be good to go.

nemo_curator/utils/text_utils.py Show resolved Hide resolved
requirements/requirements.txt Outdated Show resolved Hide resolved
@sarahyurick
address ryan's review
9fd2adc 
Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>
@sarahyurick
Copy link
Collaborator Author

Thanks @ryantwolf ! Updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantwolf ryantwolf Awaiting requested review from ryantwolf

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Japanese support for get_word_splitter
2 participants
@sarahyurick @ryantwolf