Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

salm export trtllm #10245

Merged
merged 1 commit into from
Aug 26, 2024
Merged

salm export trtllm #10245

merged 1 commit into from
Aug 26, 2024

Conversation

Slyne
Copy link
Contributor

@Slyne Slyne commented Aug 24, 2024

What does this PR do ?

Add SALM export

Collection: [NA] (nemo multimodal export)

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

Run export:
Please refer to https://github.com/Slyne/NeMo/blob/salm_trtllm_llm/examples/multimodal/speech_llm/export/README.md

Run deploy:

python3 NeMo/scripts/deploy/multimodal/deploy_triton.py \
        --modality="audio" \
        --visual_checkpoint=NeMo/examples/multimodal/speech_llm/export/output/speechllm_fc_llama2_7b_perception \
        --llm_checkpoint=NeMo/examples/multimodal/speech_llm/export/speechllm_fc_llama2_7b_llm_merged.nemo \
        --llm_model_type="llama" \
        --model_type="salm" \
        --triton_model_name="salm" \
        --max_input_len=4096 \
        --max_output_len=256 \
        --max_multimodal_len=3072 \
        --triton_model_repository=/tmp/trt_model_dir/

Run query:

python3 NeMo/scripts/deploy/multimodal/query.py \
        --model_name="salm" \
        --model_type="salm" \
        --input_text="Q: what's the transcription of the audio? A:" \
        --input_media=/ws/data/test-clean-processed/7729-102255-0009.wav

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Signed-off-by: slyne deng <slyned@nvidia.com>
@Slyne Slyne force-pushed the new_salm_trtllm branch 4 times, most recently from 19835fc to b672e25 Compare August 24, 2024 10:22
@Slyne
Copy link
Contributor Author

Slyne commented Aug 24, 2024

@meatybobby

Copy link
Collaborator

@meatybobby meatybobby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@meatybobby meatybobby merged commit 69973f9 into NVIDIA:main Aug 26, 2024
138 of 141 checks passed
shanmugamr1992 pushed a commit that referenced this pull request Aug 27, 2024
Signed-off-by: slyne deng <slyned@nvidia.com>
Co-authored-by: slyne deng <slyned@nvidia.com>
hemildesai pushed a commit that referenced this pull request Aug 28, 2024
Signed-off-by: slyne deng <slyned@nvidia.com>
Co-authored-by: slyne deng <slyned@nvidia.com>
JimmyZhang12 pushed a commit that referenced this pull request Aug 30, 2024
Signed-off-by: slyne deng <slyned@nvidia.com>
Co-authored-by: slyne deng <slyned@nvidia.com>
adityavavre pushed a commit to adityavavre/NeMo that referenced this pull request Sep 15, 2024
Signed-off-by: slyne deng <slyned@nvidia.com>
Co-authored-by: slyne deng <slyned@nvidia.com>
Signed-off-by: adityavavre <aditya.vavre@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants