Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nemo ux HF import tests #10274

Merged
merged 16 commits into from
Sep 27, 2024
Merged

Nemo ux HF import tests #10274

merged 16 commits into from
Sep 27, 2024

Conversation

akoumpa
Copy link
Collaborator

@akoumpa akoumpa commented Aug 27, 2024

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@akoumpa akoumpa changed the title Add __all__ for mistral & mixtral Nemo ux HF import tests Aug 27, 2024
@akoumpa akoumpa force-pushed the akoumparouli/nemo_ux_ckpt_import_test branch from 12b2655 to 3ddc070 Compare August 27, 2024 21:24
@github-actions github-actions bot added the CI label Aug 27, 2024
@akoumpa akoumpa self-assigned this Aug 27, 2024
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
@akoumpa akoumpa force-pushed the akoumparouli/nemo_ux_ckpt_import_test branch from 3ce7df8 to abb6bd6 Compare August 27, 2024 21:27
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
@akoumpa akoumpa force-pushed the akoumparouli/nemo_ux_ckpt_import_test branch from b55a417 to 8a76d36 Compare August 27, 2024 21:33
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
@akoumpa akoumpa force-pushed the akoumparouli/nemo_ux_ckpt_import_test branch from 9773ffd to 7ebf8d8 Compare August 27, 2024 21:49
Signed-off-by: akoumpa <akoumpa@users.noreply.github.com>
@akoumpa akoumpa added Run CICD and removed Run CICD labels Aug 27, 2024
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
@akoumpa akoumpa added Run CICD and removed Run CICD labels Aug 27, 2024
ko3n1g
ko3n1g previously approved these changes Aug 28, 2024
Copy link
Collaborator

@ko3n1g ko3n1g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, please merge right after CI pass

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
@akoumpa akoumpa added Run CICD and removed Run CICD labels Aug 28, 2024
@akoumpa akoumpa added Run CICD and removed Run CICD labels Sep 3, 2024
Signed-off-by: Alexandros Koumparoulis <153118171+akoumpa@users.noreply.github.com>
@akoumpa akoumpa added Run CICD and removed Run CICD labels Sep 19, 2024
Signed-off-by: Alexandros Koumparoulis <153118171+akoumpa@users.noreply.github.com>
@akoumpa akoumpa added Run CICD and removed Run CICD labels Sep 25, 2024
@akoumpa akoumpa added Run CICD and removed Run CICD labels Sep 26, 2024
Copy link
Contributor

[🤖]: Hi @akoumpa 👋,

I just wanted to let you know that, you know, a CICD pipeline for this PR just finished successfully ✨

So it might be time to merge this PR or like to get some approvals 🚀

But I'm just a 🤖 so I'll leave it you what to do next.

Have a great day!

//cc @ko3n1g

@akoumpa akoumpa merged commit 5b88aaa into main Sep 27, 2024
352 of 454 checks passed
@akoumpa akoumpa deleted the akoumparouli/nemo_ux_ckpt_import_test branch September 27, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants