Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRT-LLM 0.12 + ModelOpt 0.17.0 updates #10301

Merged
merged 5 commits into from
Aug 29, 2024

Conversation

janekl
Copy link
Collaborator

@janekl janekl commented Aug 29, 2024

What does this PR do ?

Updating PTQ workflow for the latest stack.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
@janekl janekl force-pushed the jlasek/trtllm_0_12_and_modelopt_0_17_updates branch from 02ae7fa to ca875b5 Compare August 29, 2024 15:48
Copy link
Collaborator

@oyilmaz-nvidia oyilmaz-nvidia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@janekl janekl added Run CICD and removed Run CICD labels Aug 29, 2024
@janekl janekl merged commit ea0f69f into main Aug 29, 2024
131 checks passed
@janekl janekl deleted the jlasek/trtllm_0_12_and_modelopt_0_17_updates branch August 29, 2024 19:47
adityavavre pushed a commit to adityavavre/NeMo that referenced this pull request Sep 15, 2024
* Update trtllm-build options

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>

* Pull QUANT_CFG_CHOICES into try/catch for HAVE_MODELOPT consistency

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>

* Remove deprecated parallel group setup

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>

* Remove deprecated size settings

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>

* Use max_seq_len instead of max_output_len [part I]

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>

---------

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: adityavavre <aditya.vavre@gmail.com>
monica-sekoyan pushed a commit that referenced this pull request Oct 14, 2024
* Update trtllm-build options

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>

* Pull QUANT_CFG_CHOICES into try/catch for HAVE_MODELOPT consistency

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>

* Remove deprecated parallel group setup

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>

* Remove deprecated size settings

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>

* Use max_seq_len instead of max_output_len [part I]

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>

---------

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
tomlifu pushed a commit to tomlifu/NeMo that referenced this pull request Oct 25, 2024
* Update trtllm-build options

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>

* Pull QUANT_CFG_CHOICES into try/catch for HAVE_MODELOPT consistency

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>

* Remove deprecated parallel group setup

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>

* Remove deprecated size settings

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>

* Use max_seq_len instead of max_output_len [part I]

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>

---------

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: Lifu Zhang <tomzhanglf@gmail.com>
tomlifu pushed a commit to tomlifu/NeMo that referenced this pull request Oct 25, 2024
* Update trtllm-build options

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>

* Pull QUANT_CFG_CHOICES into try/catch for HAVE_MODELOPT consistency

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>

* Remove deprecated parallel group setup

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>

* Remove deprecated size settings

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>

* Use max_seq_len instead of max_output_len [part I]

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>

---------

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: Lifu Zhang <tomzhanglf@gmail.com>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 5, 2024
* Update trtllm-build options

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>

* Pull QUANT_CFG_CHOICES into try/catch for HAVE_MODELOPT consistency

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>

* Remove deprecated parallel group setup

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>

* Remove deprecated size settings

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>

* Use max_seq_len instead of max_output_len [part I]

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>

---------

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants