-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TRT-LLM 0.12 + ModelOpt 0.17.0 updates #10301
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
janekl
force-pushed
the
jlasek/trtllm_0_12_and_modelopt_0_17_updates
branch
from
August 29, 2024 15:48
02ae7fa
to
ca875b5
Compare
oyilmaz-nvidia
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
adityavavre
pushed a commit
to adityavavre/NeMo
that referenced
this pull request
Sep 15, 2024
* Update trtllm-build options Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Pull QUANT_CFG_CHOICES into try/catch for HAVE_MODELOPT consistency Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Remove deprecated parallel group setup Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Remove deprecated size settings Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Use max_seq_len instead of max_output_len [part I] Signed-off-by: Jan Lasek <janek.lasek@gmail.com> --------- Signed-off-by: Jan Lasek <janek.lasek@gmail.com> Signed-off-by: adityavavre <aditya.vavre@gmail.com>
monica-sekoyan
pushed a commit
that referenced
this pull request
Oct 14, 2024
* Update trtllm-build options Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Pull QUANT_CFG_CHOICES into try/catch for HAVE_MODELOPT consistency Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Remove deprecated parallel group setup Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Remove deprecated size settings Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Use max_seq_len instead of max_output_len [part I] Signed-off-by: Jan Lasek <janek.lasek@gmail.com> --------- Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
tomlifu
pushed a commit
to tomlifu/NeMo
that referenced
this pull request
Oct 25, 2024
* Update trtllm-build options Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Pull QUANT_CFG_CHOICES into try/catch for HAVE_MODELOPT consistency Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Remove deprecated parallel group setup Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Remove deprecated size settings Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Use max_seq_len instead of max_output_len [part I] Signed-off-by: Jan Lasek <janek.lasek@gmail.com> --------- Signed-off-by: Jan Lasek <janek.lasek@gmail.com> Signed-off-by: Lifu Zhang <tomzhanglf@gmail.com>
tomlifu
pushed a commit
to tomlifu/NeMo
that referenced
this pull request
Oct 25, 2024
* Update trtllm-build options Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Pull QUANT_CFG_CHOICES into try/catch for HAVE_MODELOPT consistency Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Remove deprecated parallel group setup Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Remove deprecated size settings Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Use max_seq_len instead of max_output_len [part I] Signed-off-by: Jan Lasek <janek.lasek@gmail.com> --------- Signed-off-by: Jan Lasek <janek.lasek@gmail.com> Signed-off-by: Lifu Zhang <tomzhanglf@gmail.com>
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Nov 5, 2024
* Update trtllm-build options Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Pull QUANT_CFG_CHOICES into try/catch for HAVE_MODELOPT consistency Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Remove deprecated parallel group setup Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Remove deprecated size settings Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Use max_seq_len instead of max_output_len [part I] Signed-off-by: Jan Lasek <janek.lasek@gmail.com> --------- Signed-off-by: Jan Lasek <janek.lasek@gmail.com> Signed-off-by: Hainan Xu <hainanx@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Updating PTQ workflow for the latest stack.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use this
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information