Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flexible passing args to TensorRTLLM in nemo_export.py #10315

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

janekl
Copy link
Collaborator

@janekl janekl commented Aug 30, 2024

What does this PR do ?

Enabling user to pass arguments in nemo_export.py to TensorRT-LLM.export as the build API is constantly changing and besides some parameters needs to be set on per-model basis.

Collection: NLP

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

python tests/export/nemo_export.py \
    --model_name=$MODEL_NAME \
    ...
    --trt_llm_export_kwargs='{"reduce_fusion": false, "gemm_plugin": "auto"}'

Default value or specyfing --trt_llm_export_kwargs='{}' results in empty kwargs.

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Copy link
Collaborator

@oyilmaz-nvidia oyilmaz-nvidia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@janekl janekl merged commit 1ce9089 into main Aug 30, 2024
131 checks passed
@janekl janekl deleted the jlasek/trt_llm_export_kwargs branch August 30, 2024 12:05
BoxiangW pushed a commit to BoxiangW/NeMo that referenced this pull request Sep 4, 2024
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
adityavavre pushed a commit to adityavavre/NeMo that referenced this pull request Sep 15, 2024
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: adityavavre <aditya.vavre@gmail.com>
monica-sekoyan pushed a commit that referenced this pull request Oct 14, 2024
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
tomlifu pushed a commit to tomlifu/NeMo that referenced this pull request Oct 25, 2024
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: Lifu Zhang <tomzhanglf@gmail.com>
tomlifu pushed a commit to tomlifu/NeMo that referenced this pull request Oct 25, 2024
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: Lifu Zhang <tomzhanglf@gmail.com>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 5, 2024
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants