remove exp dir #10460
Merged
remove exp dir #10460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JRD971000
force-pushed
the
alit/temp_fix_ssm_test
branch
from
2f71c97
to
3be406a
Compare
Signed-off-by: JRD971000 <JRD971000@users.noreply.github.com>
8 tasks
ko3n1g
requested changes
Sep 22, 2024
ko3n1g
previously approved these changes
Sep 22, 2024
@ko3n1g of course, will let them know. Could you please approve this again? I needed to update some parameter naming. |
ko3n1g
approved these changes
Sep 22, 2024
rachitgarg91
pushed a commit
to rachitgarg91/NeMo
that referenced
this pull request
Sep 26, 2024
* remove exp dir * add back tests * Apply isort and black reformatting Signed-off-by: JRD971000 <JRD971000@users.noreply.github.com> * add run_id to dir * fix dir->log_dir --------- Signed-off-by: JRD971000 <JRD971000@users.noreply.github.com> Co-authored-by: JRD971000 <JRD971000@users.noreply.github.com>
monica-sekoyan
pushed a commit
that referenced
this pull request
Oct 14, 2024
* remove exp dir * add back tests * Apply isort and black reformatting Signed-off-by: JRD971000 <JRD971000@users.noreply.github.com> * add run_id to dir * fix dir->log_dir --------- Signed-off-by: JRD971000 <JRD971000@users.noreply.github.com> Co-authored-by: JRD971000 <JRD971000@users.noreply.github.com>
tomlifu
pushed a commit
to tomlifu/NeMo
that referenced
this pull request
Oct 25, 2024
* remove exp dir * add back tests * Apply isort and black reformatting Signed-off-by: JRD971000 <JRD971000@users.noreply.github.com> * add run_id to dir * fix dir->log_dir --------- Signed-off-by: JRD971000 <JRD971000@users.noreply.github.com> Co-authored-by: JRD971000 <JRD971000@users.noreply.github.com> Signed-off-by: Lifu Zhang <tomzhanglf@gmail.com>
tomlifu
pushed a commit
to tomlifu/NeMo
that referenced
this pull request
Oct 25, 2024
* remove exp dir * add back tests * Apply isort and black reformatting Signed-off-by: JRD971000 <JRD971000@users.noreply.github.com> * add run_id to dir * fix dir->log_dir --------- Signed-off-by: JRD971000 <JRD971000@users.noreply.github.com> Co-authored-by: JRD971000 <JRD971000@users.noreply.github.com> Signed-off-by: Lifu Zhang <tomzhanglf@gmail.com>
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Nov 5, 2024
* remove exp dir * add back tests * Apply isort and black reformatting Signed-off-by: JRD971000 <JRD971000@users.noreply.github.com> * add run_id to dir * fix dir->log_dir --------- Signed-off-by: JRD971000 <JRD971000@users.noreply.github.com> Co-authored-by: JRD971000 <JRD971000@users.noreply.github.com> Signed-off-by: Hainan Xu <hainanx@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information