Fix asr warnings #10469
Merged
Fix asr warnings #10469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 10, 2024 08:28
Signed-off-by: Nithin Rao Koluguri <nithinraok>
Signed-off-by: Nithin Rao Koluguri <nithinraok>
Signed-off-by: nithinraok <nithinraok@users.noreply.github.com>
titu1994
previously approved these changes
Sep 11, 2024
Signed-off-by: Nithin Rao Koluguri <nithinraok>
Signed-off-by: Nithin Rao Koluguri <nithinraok>
Signed-off-by: nithinraok <nithinraok@users.noreply.github.com>
…o fix_asr_warnings
Signed-off-by: Nithin Rao Koluguri <nithinraok>
Signed-off-by: nithinraok <nithinraok@users.noreply.github.com>
Signed-off-by: Nithin Rao Koluguri <nithinraok>
stevehuang52
previously approved these changes
Sep 16, 2024
Signed-off-by: Nithin Rao Koluguri <nithinraok>
|
[🤖]: Hi @nithinraok 👋, I just wanted to let you know that, you know, a CICD pipeline for this PR just finished successfully ✨ So it might be time to merge this PR or like to get some approvals 🚀 But I'm just a 🤖 so I'll leave it you what to do next. Have a great day! //cc @ko3n1g |
|
In CI-CD stage for more than a week. Merging as it was failing for LLM issues unrelated to this PR. |
ko3n1g
pushed a commit
that referenced
this pull request
Sep 26, 2024
* check Signed-off-by: Nithin Rao Koluguri <nithinraok> * 1 Signed-off-by: Nithin Rao Koluguri <nithinraok> * added to examples/asr Signed-off-by: Nithin Rao Koluguri <nithinraok> * deprecates cuda.amp.autocast to replace with amp.autocast(**Args) Signed-off-by: Nithin Rao Koluguri <nithinraok> * Apply isort and black reformatting Signed-off-by: nithinraok <nithinraok@users.noreply.github.com> * check Signed-off-by: Nithin Rao Koluguri <nithinraok> * 1 Signed-off-by: Nithin Rao Koluguri <nithinraok> * added to examples/asr Signed-off-by: Nithin Rao Koluguri <nithinraok> * deprecates cuda.amp.autocast to replace with amp.autocast(**Args) Signed-off-by: Nithin Rao Koluguri <nithinraok> * Apply isort and black reformatting Signed-off-by: nithinraok <nithinraok@users.noreply.github.com> * tested on V100 Signed-off-by: Nithin Rao Koluguri <nithinraok> * Apply isort and black reformatting Signed-off-by: nithinraok <nithinraok@users.noreply.github.com> * replace cuda for jit scripted modules Signed-off-by: Nithin Rao Koluguri <nithinraok> * device type fix Signed-off-by: Nithin Rao Koluguri <nithinraok> * revert diar for CI Signed-off-by: Nithin Rao Koluguri <nithinraok> --------- Signed-off-by: Nithin Rao Koluguri <nithinraok> Signed-off-by: nithinraok <nithinraok@users.noreply.github.com> Co-authored-by: Nithin Rao Koluguri <nithinraok> Co-authored-by: nithinraok <nithinraok@users.noreply.github.com>
rachitgarg91
pushed a commit
to rachitgarg91/NeMo
that referenced
this pull request
Sep 26, 2024
* check Signed-off-by: Nithin Rao Koluguri <nithinraok> * 1 Signed-off-by: Nithin Rao Koluguri <nithinraok> * added to examples/asr Signed-off-by: Nithin Rao Koluguri <nithinraok> * deprecates cuda.amp.autocast to replace with amp.autocast(**Args) Signed-off-by: Nithin Rao Koluguri <nithinraok> * Apply isort and black reformatting Signed-off-by: nithinraok <nithinraok@users.noreply.github.com> * check Signed-off-by: Nithin Rao Koluguri <nithinraok> * 1 Signed-off-by: Nithin Rao Koluguri <nithinraok> * added to examples/asr Signed-off-by: Nithin Rao Koluguri <nithinraok> * deprecates cuda.amp.autocast to replace with amp.autocast(**Args) Signed-off-by: Nithin Rao Koluguri <nithinraok> * Apply isort and black reformatting Signed-off-by: nithinraok <nithinraok@users.noreply.github.com> * tested on V100 Signed-off-by: Nithin Rao Koluguri <nithinraok> * Apply isort and black reformatting Signed-off-by: nithinraok <nithinraok@users.noreply.github.com> * replace cuda for jit scripted modules Signed-off-by: Nithin Rao Koluguri <nithinraok> * device type fix Signed-off-by: Nithin Rao Koluguri <nithinraok> * revert diar for CI Signed-off-by: Nithin Rao Koluguri <nithinraok> --------- Signed-off-by: Nithin Rao Koluguri <nithinraok> Signed-off-by: nithinraok <nithinraok@users.noreply.github.com> Co-authored-by: Nithin Rao Koluguri <nithinraok> Co-authored-by: nithinraok <nithinraok@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Replaces deprecated cuda.amp.autocast with amp.autocast(**Args)
Collection: All (majorly ASR, TTS, Audio)
Changelog
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information