Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update modelopt to 0.17.0 #10489

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Update modelopt to 0.17.0 #10489

merged 2 commits into from
Sep 18, 2024

Conversation

janekl
Copy link
Collaborator

@janekl janekl commented Sep 16, 2024

What does this PR do ?

Updating modelopt to 0.17.0

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
@janekl
Copy link
Collaborator Author

janekl commented Sep 16, 2024

May I ask for your approval @pablo-garay as this updates Dockerfile.ci? Thanks

@janekl
Copy link
Collaborator Author

janekl commented Sep 17, 2024

May I ask for your approval @pablo-garay as this updates Dockerfile.ci? Thanks

Or @ko3n1g... thanks : )

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
@janekl janekl added Run CICD and removed Run CICD labels Sep 18, 2024
@janekl janekl merged commit bb4b5c6 into main Sep 18, 2024
151 of 155 checks passed
@janekl janekl deleted the jlasek/modelopt_update_0_17_0 branch September 18, 2024 16:19
gwarmstrong pushed a commit to gwarmstrong/NeMo that referenced this pull request Sep 19, 2024
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: George Armstrong <georgea@nvidia.com>
monica-sekoyan pushed a commit that referenced this pull request Oct 14, 2024
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
tomlifu pushed a commit to tomlifu/NeMo that referenced this pull request Oct 25, 2024
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: Lifu Zhang <tomzhanglf@gmail.com>
tomlifu pushed a commit to tomlifu/NeMo that referenced this pull request Oct 25, 2024
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: Lifu Zhang <tomzhanglf@gmail.com>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 5, 2024
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants