Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Clip initializing issue in r2.0.0 #10585

Merged
merged 4 commits into from
Sep 26, 2024
Merged

Fix Clip initializing issue in r2.0.0 #10585

merged 4 commits into from
Sep 26, 2024

Conversation

yaoyu-33
Copy link
Collaborator

What does this PR do ?

Fix Clip initializing issue in r2.0.0

Collection: [multimodal]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Victor49152
Victor49152 previously approved these changes Sep 23, 2024
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Signed-off-by: yaoyu-33 <yaoyu-33@users.noreply.github.com>
@yaoyu-33 yaoyu-33 merged commit 016c1e4 into main Sep 26, 2024
152 of 158 checks passed
@yaoyu-33 yaoyu-33 deleted the yuya/fix_clip_r2.0.0 branch September 26, 2024 15:03
ko3n1g pushed a commit that referenced this pull request Sep 26, 2024
* update post process

Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>

* Fix wild card matching in nemo2

Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>

* Apply isort and black reformatting

Signed-off-by: yaoyu-33 <yaoyu-33@users.noreply.github.com>

---------

Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Signed-off-by: yaoyu-33 <yaoyu-33@users.noreply.github.com>
Co-authored-by: yaoyu-33 <yaoyu-33@users.noreply.github.com>
rachitgarg91 pushed a commit to rachitgarg91/NeMo that referenced this pull request Sep 26, 2024
* update post process

Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>

* Fix wild card matching in nemo2

Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>

* Apply isort and black reformatting

Signed-off-by: yaoyu-33 <yaoyu-33@users.noreply.github.com>

---------

Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Signed-off-by: yaoyu-33 <yaoyu-33@users.noreply.github.com>
Co-authored-by: yaoyu-33 <yaoyu-33@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants