Akoumparouli/nemo ux test fixes #10641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akoumpa
force-pushed
the
akoumparouli/nemo_ux_test_fixes
branch
from
3679c7c
to
195adff
Compare
akoumpa
force-pushed
the
akoumparouli/nemo_ux_test_fixes
branch
from
195adff
to
a6160e2
Compare
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
…os.environ :( to avoid interference from other tests Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
akoumpa
force-pushed
the
akoumparouli/nemo_ux_test_fixes
branch
from
31b11d7
to
c92fb45
Compare
Signed-off-by: akoumpa <akoumpa@users.noreply.github.com>
ko3n1g
approved these changes
Oct 4, 2024
|
[🤖]: Hi @akoumpa 👋, I just wanted to let you know that, you know, a CICD pipeline for this PR just finished successfully ✨ So it might be time to merge this PR or like to get some approvals 🚀 But I'm just a 🤖 so I'll leave it you what to do next. Have a great day! //cc @ko3n1g |
akoumpa
added a commit
that referenced
this pull request
Oct 4, 2024
* NeMoLogger arg rename dir -> log_dir Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * Set NVTE_APPLY_QK_LAYER_SCALING=0 Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * call mbs reconfigure to avoid interference from other tests; rewrite os.environ :( to avoid interference from other tests Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * Apply isort and black reformatting Signed-off-by: akoumpa <akoumpa@users.noreply.github.com> --------- Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> Signed-off-by: akoumpa <akoumpa@users.noreply.github.com> Co-authored-by: akoumpa <akoumpa@users.noreply.github.com>
akoumpa
added a commit
that referenced
this pull request
Oct 4, 2024
* NeMoLogger arg rename dir -> log_dir * Set NVTE_APPLY_QK_LAYER_SCALING=0 * call mbs reconfigure to avoid interference from other tests; rewrite os.environ :( to avoid interference from other tests * Apply isort and black reformatting --------- Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> Signed-off-by: akoumpa <akoumpa@users.noreply.github.com> Co-authored-by: akoumpa <akoumpa@users.noreply.github.com>
monica-sekoyan
pushed a commit
that referenced
this pull request
Oct 14, 2024
* NeMoLogger arg rename dir -> log_dir Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * Set NVTE_APPLY_QK_LAYER_SCALING=0 Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * call mbs reconfigure to avoid interference from other tests; rewrite os.environ :( to avoid interference from other tests Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * Apply isort and black reformatting Signed-off-by: akoumpa <akoumpa@users.noreply.github.com> --------- Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> Signed-off-by: akoumpa <akoumpa@users.noreply.github.com> Co-authored-by: akoumpa <akoumpa@users.noreply.github.com>
yashaswikarnati
pushed a commit
that referenced
this pull request
Oct 20, 2024
* NeMoLogger arg rename dir -> log_dir Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * Set NVTE_APPLY_QK_LAYER_SCALING=0 Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * call mbs reconfigure to avoid interference from other tests; rewrite os.environ :( to avoid interference from other tests Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * Apply isort and black reformatting Signed-off-by: akoumpa <akoumpa@users.noreply.github.com> --------- Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> Signed-off-by: akoumpa <akoumpa@users.noreply.github.com> Co-authored-by: akoumpa <akoumpa@users.noreply.github.com>
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Nov 5, 2024
* NeMoLogger arg rename dir -> log_dir Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * Set NVTE_APPLY_QK_LAYER_SCALING=0 Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * call mbs reconfigure to avoid interference from other tests; rewrite os.environ :( to avoid interference from other tests Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * Apply isort and black reformatting Signed-off-by: akoumpa <akoumpa@users.noreply.github.com> --------- Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> Signed-off-by: akoumpa <akoumpa@users.noreply.github.com> Co-authored-by: akoumpa <akoumpa@users.noreply.github.com> Signed-off-by: Hainan Xu <hainanx@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Are both stateful when multiple tests are run in the same process.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information