Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NeMo-UX] Fix when optimizers are setup for PEFT #9619

Merged
merged 17 commits into from
Jul 9, 2024
Merged

[NeMo-UX] Fix when optimizers are setup for PEFT #9619

merged 17 commits into from
Jul 9, 2024

Commits on Jul 8, 2024

  1. Fix when optimizers are setup for PEFT

    @marcromeyn
    marcromeyn committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    a835e80 View commit details
    Browse the repository at this point in the history

  2. Apply isort and black reformatting 

    Signed-off-by: marcromeyn <marcromeyn@users.noreply.github.com>
    @marcromeyn
    marcromeyn committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    8cd2b61 View commit details
    Browse the repository at this point in the history

  3. Init DDP inside PEFT

    @marcromeyn
    marcromeyn committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    470f8af View commit details
    Browse the repository at this point in the history

  4. Apply isort and black reformatting 

    Signed-off-by: marcromeyn <marcromeyn@users.noreply.github.com>
    @marcromeyn
    marcromeyn committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    6a34a88 View commit details
    Browse the repository at this point in the history

  5. Some fixes, loss seems to become nan with peft for some reason

    @marcromeyn
    marcromeyn committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    dc63653 View commit details
    Browse the repository at this point in the history

  6. Apply isort and black reformatting 

    Signed-off-by: marcromeyn <marcromeyn@users.noreply.github.com>
    @marcromeyn
    marcromeyn committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    ee43c65 View commit details
    Browse the repository at this point in the history

  7. Loss goes down on fp32

    @marcromeyn
    marcromeyn committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    ab4e73c View commit details
    Browse the repository at this point in the history

  8. Apply isort and black reformatting 

    Signed-off-by: marcromeyn <marcromeyn@users.noreply.github.com>
    @marcromeyn
    marcromeyn committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    5cf8053 View commit details
    Browse the repository at this point in the history

  9. Simplifying FNMixin

    @marcromeyn
    marcromeyn committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    31f2ff1 View commit details
    Browse the repository at this point in the history

  10. Apply isort and black reformatting 

    Signed-off-by: marcromeyn <marcromeyn@users.noreply.github.com>
    @marcromeyn
    marcromeyn committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    5cba5d5 View commit details
    Browse the repository at this point in the history

  11. Fix bug with new checkpoint-io

    @marcromeyn
    marcromeyn committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    fd1755b View commit details
    Browse the repository at this point in the history

  12. Apply isort and black reformatting 

    Signed-off-by: marcromeyn <marcromeyn@users.noreply.github.com>
    @marcromeyn
    marcromeyn committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    ea5059a View commit details
    Browse the repository at this point in the history

  13. Merge branch 'main' into nemo-ux/peft-fix

    @marcromeyn
    marcromeyn authored Jul 8, 2024
    Configuration menu
    Copy the full SHA
    89250d3 View commit details
    Browse the repository at this point in the history

  14. Fix failing test: test_peft_on_train_epoch_start_with_adapter

    @marcromeyn
    marcromeyn committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    df39e7c View commit details
    Browse the repository at this point in the history

  15. Apply isort and black reformatting 

    Signed-off-by: marcromeyn <marcromeyn@users.noreply.github.com>
    @marcromeyn
    marcromeyn committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    0e8aca1 View commit details
    Browse the repository at this point in the history

  16. Merge branch 'main' into nemo-ux/peft-fix

    @marcromeyn
    marcromeyn authored Jul 8, 2024
    Configuration menu
    Copy the full SHA
    f4de339 View commit details
    Browse the repository at this point in the history

  17. Merge branch 'r2.0.0rc1' into nemo-ux/peft-fix

    @cuichenx
    cuichenx authored Jul 8, 2024
    Configuration menu
    Copy the full SHA
    2e907ac View commit details
    Browse the repository at this point in the history