Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Nemo-UX] Including all trainable-params in a PEFT-checkpoint #9650

Merged
merged 8 commits into from
Jul 11, 2024
Merged

[Nemo-UX] Including all trainable-params in a PEFT-checkpoint #9650

merged 8 commits into from
Jul 11, 2024

Conversation

marcromeyn
Copy link
Collaborator

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

borisfom and others added 2 commits July 9, 2024 00:55
@borisfom @ericharper @marcromeyn
Nemotron export - fixing megatron_export.py (#9625)
9b27c3b 
* Nemotron ONNX export fixed

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

* Cleanup

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

* Addressing code review comments

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

---------

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
Co-authored-by: Eric Harper <complex451@gmail.com>
@marcromeyn
Including all trainable-params in a PEFT-checkpoint
0fea812
@marcromeyn marcromeyn requested a review from cuichenx July 9, 2024 12:29
@marcromeyn
Apply isort and black reformatting
cb15a59 
Signed-off-by: marcromeyn <marcromeyn@users.noreply.github.com>
cuichenx
cuichenx previously approved these changes Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@cuichenx cuichenx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcromeyn marcromeyn merged commit 1e20a8e into r2.0.0rc1 Jul 11, 2024
113 of 114 checks passed
@marcromeyn marcromeyn deleted the nemo-ux/adapter-weights branch July 11, 2024 12:56
github-actions bot pushed a commit that referenced this pull request Jul 11, 2024
@marcromeyn @borisfom
@ericharper @cuichenx @web-flow
[Nemo-UX] Including all trainable-params in a PEFT-checkpoint (#9650)
2fecd85 
* Nemotron export - fixing megatron_export.py  (#9625)

* Nemotron ONNX export fixed

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

* Cleanup

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

* Addressing code review comments

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

---------

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
Co-authored-by: Eric Harper <complex451@gmail.com>

* Including all trainable-params in a PEFT-checkpoint

* Apply isort and black reformatting

Signed-off-by: marcromeyn <marcromeyn@users.noreply.github.com>

* Small fixes to make model-importer work

* Fixing failing tests

---------

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
Signed-off-by: marcromeyn <marcromeyn@users.noreply.github.com>
Co-authored-by: Boris Fomitchev <borisfom@users.noreply.github.com>
Co-authored-by: Eric Harper <complex451@gmail.com>
Co-authored-by: marcromeyn <marcromeyn@users.noreply.github.com>
Co-authored-by: Chen Cui <chcui@nvidia.com>
maanug-nv pushed a commit that referenced this pull request Jul 14, 2024
@marcromeyn @borisfom
@ericharper @cuichenx @maanug-nv
[Nemo-UX] Including all trainable-params in a PEFT-checkpoint (#9650)
bb08b53 
* Nemotron export - fixing megatron_export.py  (#9625)

* Nemotron ONNX export fixed

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

* Cleanup

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

* Addressing code review comments

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>

---------

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
Co-authored-by: Eric Harper <complex451@gmail.com>

* Including all trainable-params in a PEFT-checkpoint

* Apply isort and black reformatting

Signed-off-by: marcromeyn <marcromeyn@users.noreply.github.com>

* Small fixes to make model-importer work

* Fixing failing tests

---------

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
Signed-off-by: marcromeyn <marcromeyn@users.noreply.github.com>
Co-authored-by: Boris Fomitchev <borisfom@users.noreply.github.com>
Co-authored-by: Eric Harper <complex451@gmail.com>
Co-authored-by: marcromeyn <marcromeyn@users.noreply.github.com>
Co-authored-by: Chen Cui <chcui@nvidia.com>
ashors1 added a commit that referenced this pull request Jul 15, 2024
@github-actions @marcromeyn
@borisfom @ericharper @cuichenx @ashors1
[Nemo-UX] Including all trainable-params in a PEFT-checkpoint (#9650) (…
8128122 
…#9691)

* Nemotron export - fixing megatron_export.py  (#9625)

* Nemotron ONNX export fixed



* Cleanup



* Addressing code review comments



---------




* Including all trainable-params in a PEFT-checkpoint

* Apply isort and black reformatting



* Small fixes to make model-importer work

* Fixing failing tests

---------

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
Signed-off-by: marcromeyn <marcromeyn@users.noreply.github.com>
Co-authored-by: Marc Romeyn <mromeijn@nvidia.com>
Co-authored-by: Boris Fomitchev <borisfom@users.noreply.github.com>
Co-authored-by: Eric Harper <complex451@gmail.com>
Co-authored-by: marcromeyn <marcromeyn@users.noreply.github.com>
Co-authored-by: Chen Cui <chcui@nvidia.com>
Co-authored-by: ashors1 <ashors@nvidia.com>
nikitaved pushed a commit to nikitaved/NeMo that referenced this pull request Jul 16, 2024
@github-actions @marcromeyn
@borisfom @ericharper @cuichenx @ashors1 @nikitaved
[Nemo-UX] Including all trainable-params in a PEFT-checkpoint (NVIDIA…
cb4f06e 
…#9650) (NVIDIA#9691)

* Nemotron export - fixing megatron_export.py  (NVIDIA#9625)

* Nemotron ONNX export fixed



* Cleanup



* Addressing code review comments



---------




* Including all trainable-params in a PEFT-checkpoint

* Apply isort and black reformatting



* Small fixes to make model-importer work

* Fixing failing tests

---------

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
Signed-off-by: marcromeyn <marcromeyn@users.noreply.github.com>
Co-authored-by: Marc Romeyn <mromeijn@nvidia.com>
Co-authored-by: Boris Fomitchev <borisfom@users.noreply.github.com>
Co-authored-by: Eric Harper <complex451@gmail.com>
Co-authored-by: marcromeyn <marcromeyn@users.noreply.github.com>
Co-authored-by: Chen Cui <chcui@nvidia.com>
Co-authored-by: ashors1 <ashors@nvidia.com>
@ko3n1g ko3n1g mentioned this pull request Jul 18, 2024
Closed
2 tasks
ertkonuk pushed a commit that referenced this pull request Jul 19, 2024
@github-actions @marcromeyn
@borisfom @ericharper @cuichenx @ashors1 @ertkonuk
[Nemo-UX] Including all trainable-params in a PEFT-checkpoint (#9650) (…
bfcc5ae 
…#9691)

* Nemotron export - fixing megatron_export.py  (#9625)

* Nemotron ONNX export fixed



* Cleanup



* Addressing code review comments



---------




* Including all trainable-params in a PEFT-checkpoint

* Apply isort and black reformatting



* Small fixes to make model-importer work

* Fixing failing tests

---------

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
Signed-off-by: marcromeyn <marcromeyn@users.noreply.github.com>
Co-authored-by: Marc Romeyn <mromeijn@nvidia.com>
Co-authored-by: Boris Fomitchev <borisfom@users.noreply.github.com>
Co-authored-by: Eric Harper <complex451@gmail.com>
Co-authored-by: marcromeyn <marcromeyn@users.noreply.github.com>
Co-authored-by: Chen Cui <chcui@nvidia.com>
Co-authored-by: ashors1 <ashors@nvidia.com>
Signed-off-by: Tugrul Konuk <ertkonuk@gmail.com>
malay-nagda pushed a commit to malay-nagda/NeMo that referenced this pull request Jul 26, 2024
@github-actions @marcromeyn
@borisfom @ericharper @cuichenx @ashors1
[Nemo-UX] Including all trainable-params in a PEFT-checkpoint (NVIDIA…
6384d5a 
…#9650) (NVIDIA#9691)

* Nemotron export - fixing megatron_export.py  (NVIDIA#9625)

* Nemotron ONNX export fixed

* Cleanup

* Addressing code review comments

---------

* Including all trainable-params in a PEFT-checkpoint

* Apply isort and black reformatting

* Small fixes to make model-importer work

* Fixing failing tests

---------

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
Signed-off-by: marcromeyn <marcromeyn@users.noreply.github.com>
Co-authored-by: Marc Romeyn <mromeijn@nvidia.com>
Co-authored-by: Boris Fomitchev <borisfom@users.noreply.github.com>
Co-authored-by: Eric Harper <complex451@gmail.com>
Co-authored-by: marcromeyn <marcromeyn@users.noreply.github.com>
Co-authored-by: Chen Cui <chcui@nvidia.com>
Co-authored-by: ashors1 <ashors@nvidia.com>
Signed-off-by: Malay Nagda <malayn@malayn-mlt.client.nvidia.com>
tonyjie pushed a commit to tonyjie/NeMo that referenced this pull request Aug 6, 2024
@github-actions @marcromeyn
@borisfom @ericharper @cuichenx @ashors1 @tonyjie
[Nemo-UX] Including all trainable-params in a PEFT-checkpoint (NVIDIA…
4068586 
…#9650) (NVIDIA#9691)

* Nemotron export - fixing megatron_export.py  (NVIDIA#9625)

* Nemotron ONNX export fixed

* Cleanup

* Addressing code review comments

---------

* Including all trainable-params in a PEFT-checkpoint

* Apply isort and black reformatting

* Small fixes to make model-importer work

* Fixing failing tests

---------

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
Signed-off-by: marcromeyn <marcromeyn@users.noreply.github.com>
Co-authored-by: Marc Romeyn <mromeijn@nvidia.com>
Co-authored-by: Boris Fomitchev <borisfom@users.noreply.github.com>
Co-authored-by: Eric Harper <complex451@gmail.com>
Co-authored-by: marcromeyn <marcromeyn@users.noreply.github.com>
Co-authored-by: Chen Cui <chcui@nvidia.com>
Co-authored-by: ashors1 <ashors@nvidia.com>
Signed-off-by: tonyjie <jl4257@cornell.edu>
monica-sekoyan pushed a commit that referenced this pull request Oct 14, 2024
@github-actions @marcromeyn
@borisfom @ericharper @cuichenx @ashors1 @monica-sekoyan
[Nemo-UX] Including all trainable-params in a PEFT-checkpoint (#9650) (…
02d2395 
…#9691)

* Nemotron export - fixing megatron_export.py  (#9625)

* Nemotron ONNX export fixed



* Cleanup



* Addressing code review comments



---------




* Including all trainable-params in a PEFT-checkpoint

* Apply isort and black reformatting



* Small fixes to make model-importer work

* Fixing failing tests

---------

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
Signed-off-by: marcromeyn <marcromeyn@users.noreply.github.com>
Co-authored-by: Marc Romeyn <mromeijn@nvidia.com>
Co-authored-by: Boris Fomitchev <borisfom@users.noreply.github.com>
Co-authored-by: Eric Harper <complex451@gmail.com>
Co-authored-by: marcromeyn <marcromeyn@users.noreply.github.com>
Co-authored-by: Chen Cui <chcui@nvidia.com>
Co-authored-by: ashors1 <ashors@nvidia.com>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 5, 2024
@github-actions @marcromeyn
@borisfom @ericharper @cuichenx @ashors1
[Nemo-UX] Including all trainable-params in a PEFT-checkpoint (NVIDIA…
6579102 
…#9650) (NVIDIA#9691)

* Nemotron export - fixing megatron_export.py  (NVIDIA#9625)

* Nemotron ONNX export fixed



* Cleanup



* Addressing code review comments



---------




* Including all trainable-params in a PEFT-checkpoint

* Apply isort and black reformatting



* Small fixes to make model-importer work

* Fixing failing tests

---------

Signed-off-by: Boris Fomitchev <bfomitchev@nvidia.com>
Signed-off-by: marcromeyn <marcromeyn@users.noreply.github.com>
Co-authored-by: Marc Romeyn <mromeijn@nvidia.com>
Co-authored-by: Boris Fomitchev <borisfom@users.noreply.github.com>
Co-authored-by: Eric Harper <complex451@gmail.com>
Co-authored-by: marcromeyn <marcromeyn@users.noreply.github.com>
Co-authored-by: Chen Cui <chcui@nvidia.com>
Co-authored-by: ashors1 <ashors@nvidia.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sararb sararb sararb approved these changes

@cuichenx cuichenx cuichenx left review comments

Assignees
No one assigned
Labels
Run CICD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marcromeyn @sararb @cuichenx @borisfom