Canary Adapters tutorial #9670
Merged
Canary Adapters tutorial #9670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: smajumdar <titu1994@gmail.com>
Signed-off-by: smajumdar <titu1994@gmail.com>
Signed-off-by: smajumdar <titu1994@gmail.com>
Signed-off-by: titu1994 <titu1994@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| import os |
Check notice
Code scanning / CodeQL
Unused import Note test
| # limitations under the License. | ||
|
|
||
| import os | ||
| import tempfile |
Check notice
Code scanning / CodeQL
Unused import Note test
pzelasko
reviewed
Jul 16, 2024
| self.eval() | ||
|
|
||
| def unfreeze(self) -> None: | ||
| def unfreeze(self, partial: bool = False) -> None: |
There was a problem hiding this comment.
Regarding the name partial: my understanding is that this is intended as only_adapters=False but you don't want to name it as such to maintain separation of concerns between adapter and freeze/unfreeze APIs. I think the current name is a bit confusing when read out of the context of this PR; maybe we could at least extend the doc to explain why/when you might want to use this option?
Signed-off-by: smajumdar <titu1994@gmail.com>
Signed-off-by: smajumdar <titu1994@gmail.com>
nithinraok
pushed a commit
that referenced
this pull request
Jul 17, 2024
* Fix issue with prompt_defaults Signed-off-by: smajumdar <titu1994@gmail.com> * Add core level support for grad map tracking Signed-off-by: smajumdar <titu1994@gmail.com> * Add core level support for grad map tracking Signed-off-by: smajumdar <titu1994@gmail.com> * Apply isort and black reformatting Signed-off-by: titu1994 <titu1994@users.noreply.github.com> * Add tutorial and update repr of formatters Signed-off-by: smajumdar <titu1994@gmail.com> * Update docs Signed-off-by: smajumdar <titu1994@gmail.com> --------- Signed-off-by: smajumdar <titu1994@gmail.com> Signed-off-by: titu1994 <titu1994@users.noreply.github.com>
8 tasks
nithinraok
added a commit
that referenced
this pull request
Jul 18, 2024
ertkonuk
pushed a commit
that referenced
this pull request
Jul 19, 2024
* Fix issue with prompt_defaults Signed-off-by: smajumdar <titu1994@gmail.com> * Add core level support for grad map tracking Signed-off-by: smajumdar <titu1994@gmail.com> * Add core level support for grad map tracking Signed-off-by: smajumdar <titu1994@gmail.com> * Apply isort and black reformatting Signed-off-by: titu1994 <titu1994@users.noreply.github.com> * Add tutorial and update repr of formatters Signed-off-by: smajumdar <titu1994@gmail.com> * Update docs Signed-off-by: smajumdar <titu1994@gmail.com> --------- Signed-off-by: smajumdar <titu1994@gmail.com> Signed-off-by: titu1994 <titu1994@users.noreply.github.com> Signed-off-by: Tugrul Konuk <ertkonuk@gmail.com>
malay-nagda
pushed a commit
to malay-nagda/NeMo
that referenced
this pull request
Jul 26, 2024
* Fix issue with prompt_defaults Signed-off-by: smajumdar <titu1994@gmail.com> * Add core level support for grad map tracking Signed-off-by: smajumdar <titu1994@gmail.com> * Add core level support for grad map tracking Signed-off-by: smajumdar <titu1994@gmail.com> * Apply isort and black reformatting Signed-off-by: titu1994 <titu1994@users.noreply.github.com> * Add tutorial and update repr of formatters Signed-off-by: smajumdar <titu1994@gmail.com> * Update docs Signed-off-by: smajumdar <titu1994@gmail.com> --------- Signed-off-by: smajumdar <titu1994@gmail.com> Signed-off-by: titu1994 <titu1994@users.noreply.github.com> Signed-off-by: Malay Nagda <malayn@malayn-mlt.client.nvidia.com>
tonyjie
pushed a commit
to tonyjie/NeMo
that referenced
this pull request
Aug 6, 2024
* Fix issue with prompt_defaults Signed-off-by: smajumdar <titu1994@gmail.com> * Add core level support for grad map tracking Signed-off-by: smajumdar <titu1994@gmail.com> * Add core level support for grad map tracking Signed-off-by: smajumdar <titu1994@gmail.com> * Apply isort and black reformatting Signed-off-by: titu1994 <titu1994@users.noreply.github.com> * Add tutorial and update repr of formatters Signed-off-by: smajumdar <titu1994@gmail.com> * Update docs Signed-off-by: smajumdar <titu1994@gmail.com> --------- Signed-off-by: smajumdar <titu1994@gmail.com> Signed-off-by: titu1994 <titu1994@users.noreply.github.com> Signed-off-by: tonyjie <jl4257@cornell.edu>
monica-sekoyan
pushed a commit
that referenced
this pull request
Oct 14, 2024
* Fix issue with prompt_defaults Signed-off-by: smajumdar <titu1994@gmail.com> * Add core level support for grad map tracking Signed-off-by: smajumdar <titu1994@gmail.com> * Add core level support for grad map tracking Signed-off-by: smajumdar <titu1994@gmail.com> * Apply isort and black reformatting Signed-off-by: titu1994 <titu1994@users.noreply.github.com> * Add tutorial and update repr of formatters Signed-off-by: smajumdar <titu1994@gmail.com> * Update docs Signed-off-by: smajumdar <titu1994@gmail.com> --------- Signed-off-by: smajumdar <titu1994@gmail.com> Signed-off-by: titu1994 <titu1994@users.noreply.github.com>
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Nov 5, 2024
* Fix issue with prompt_defaults Signed-off-by: smajumdar <titu1994@gmail.com> * Add core level support for grad map tracking Signed-off-by: smajumdar <titu1994@gmail.com> * Add core level support for grad map tracking Signed-off-by: smajumdar <titu1994@gmail.com> * Apply isort and black reformatting Signed-off-by: titu1994 <titu1994@users.noreply.github.com> * Add tutorial and update repr of formatters Signed-off-by: smajumdar <titu1994@gmail.com> * Update docs Signed-off-by: smajumdar <titu1994@gmail.com> --------- Signed-off-by: smajumdar <titu1994@gmail.com> Signed-off-by: titu1994 <titu1994@users.noreply.github.com> Signed-off-by: Hainan Xu <hainanx@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Adds a tutorial for Canary Adapters
Collection: [ASR]
Changelog
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type: