Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add contianer #9731

Merged
merged 5 commits into from
Jul 15, 2024
Merged

add contianer #9731

merged 5 commits into from
Jul 15, 2024

Conversation

JRD971000
Copy link
Collaborator

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@JRD971000 JRD971000 self-assigned this Jul 15, 2024
@JRD971000 JRD971000 added the documentation Improvements or additions to documentation label Jul 15, 2024
ko3n1g
ko3n1g previously approved these changes Jul 15, 2024
Copy link
Collaborator

@ko3n1g ko3n1g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Externals don't have access our confluence

Copy link
Collaborator

@ko3n1g ko3n1g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding those explanations!

@JRD971000 JRD971000 added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Jul 15, 2024
@JRD971000 JRD971000 added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Jul 15, 2024
@JRD971000 JRD971000 merged commit a9dbe37 into main Jul 15, 2024
118 checks passed
@JRD971000 JRD971000 deleted the alit/mamba branch July 15, 2024 17:33
nikitaved pushed a commit to nikitaved/NeMo that referenced this pull request Jul 16, 2024
* add contianer

* modify tutorial

* modify tutorial

* modify tutorial

---------

Co-authored-by: Ali Taghibakhshi <ataghibakhsh@login-eos01.eos.clusters.nvidia.com>
ertkonuk pushed a commit that referenced this pull request Jul 19, 2024
* add contianer

* modify tutorial

* modify tutorial

* modify tutorial

---------

Co-authored-by: Ali Taghibakhshi <ataghibakhsh@login-eos01.eos.clusters.nvidia.com>
Signed-off-by: Tugrul Konuk <ertkonuk@gmail.com>
malay-nagda pushed a commit to malay-nagda/NeMo that referenced this pull request Jul 26, 2024
* add contianer

* modify tutorial

* modify tutorial

* modify tutorial

---------

Co-authored-by: Ali Taghibakhshi <ataghibakhsh@login-eos01.eos.clusters.nvidia.com>
Signed-off-by: Malay Nagda <malayn@malayn-mlt.client.nvidia.com>
tonyjie pushed a commit to tonyjie/NeMo that referenced this pull request Aug 6, 2024
* add contianer

* modify tutorial

* modify tutorial

* modify tutorial

---------

Co-authored-by: Ali Taghibakhshi <ataghibakhsh@login-eos01.eos.clusters.nvidia.com>
Signed-off-by: tonyjie <jl4257@cornell.edu>
monica-sekoyan pushed a commit that referenced this pull request Oct 14, 2024
* add contianer

* modify tutorial

* modify tutorial

* modify tutorial

---------

Co-authored-by: Ali Taghibakhshi <ataghibakhsh@login-eos01.eos.clusters.nvidia.com>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 5, 2024
* add contianer

* modify tutorial

* modify tutorial

* modify tutorial

---------

Co-authored-by: Ali Taghibakhshi <ataghibakhsh@login-eos01.eos.clusters.nvidia.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants