[NeMo-UX] Update default PTL logging save_dir
#9954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ashors1 <ashors@nvidia.com>
Signed-off-by: ashors1 <ashors@nvidia.com>
Signed-off-by: ashors1 <ashors@nvidia.com>
ShriyaPalsamudram
previously approved these changes
Jul 30, 2024
Signed-off-by: ashors1 <ashors@nvidia.com>
hemildesai
approved these changes
Jul 30, 2024
ShriyaPalsamudram
approved these changes
Jul 31, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jul 31, 2024
* updat default PTL logging directories Signed-off-by: ashors1 <ashors@nvidia.com> * fix logger versions Signed-off-by: ashors1 <ashors@nvidia.com> * fix failed test Signed-off-by: ashors1 <ashors@nvidia.com> * add better documentation for 'update_logger_directory' Signed-off-by: ashors1 <ashors@nvidia.com> --------- Signed-off-by: ashors1 <ashors@nvidia.com>
ashors1
added a commit
that referenced
this pull request
Aug 6, 2024
* updat default PTL logging directories * fix logger versions * fix failed test * add better documentation for 'update_logger_directory' --------- Signed-off-by: ashors1 <ashors@nvidia.com> Co-authored-by: Anna Shors <71393111+ashors1@users.noreply.github.com>
adityavavre
pushed a commit
to adityavavre/NeMo
that referenced
this pull request
Sep 15, 2024
…#9985) * updat default PTL logging directories * fix logger versions * fix failed test * add better documentation for 'update_logger_directory' --------- Signed-off-by: ashors1 <ashors@nvidia.com> Co-authored-by: Anna Shors <71393111+ashors1@users.noreply.github.com> Signed-off-by: adityavavre <aditya.vavre@gmail.com>
monica-sekoyan
pushed a commit
that referenced
this pull request
Oct 14, 2024
* updat default PTL logging directories * fix logger versions * fix failed test * add better documentation for 'update_logger_directory' --------- Signed-off-by: ashors1 <ashors@nvidia.com> Co-authored-by: Anna Shors <71393111+ashors1@users.noreply.github.com>
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Nov 5, 2024
…#9985) * updat default PTL logging directories * fix logger versions * fix failed test * add better documentation for 'update_logger_directory' --------- Signed-off-by: ashors1 <ashors@nvidia.com> Co-authored-by: Anna Shors <71393111+ashors1@users.noreply.github.com> Signed-off-by: Hainan Xu <hainanx@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
If a user passes a
save_dirto a PTL logger, by default we write the logs to<log_dir> / save_dir, where<log_dir>is determined by NeMoLogger. Previously,save_dirwas ignored, and the logs would be written to<log_dir>.Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information