Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve HTTP handler FIXME #16

Merged
merged 1 commit into from
May 11, 2018
Merged

Resolve HTTP handler FIXME #16

merged 1 commit into from
May 11, 2018

Conversation

liangdrew
Copy link
Contributor

@liangdrew liangdrew commented May 11, 2018 •
edited
Loading

This change makes the API a little more user friendly - all request URIs with the path /v1/res/ will be treated as the same URI with path /v1/res.

@usmanong
Copy link
Contributor

make two separate changes, these two are not related.
merge the failure rate change, and let people review the "/" change
thanks

@liangdrew liangdrew force-pushed the handler-fixme branch 3 times, most recently from 96d46a0 to 2340d55 Compare May 11, 2018 22:29
usmanong
usmanong approved these changes May 11, 2018
View reviewed changes
Copy link
Contributor

@usmanong usmanong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good cleanup, thanks

@liangdrew
Resolve HTTP handler FIXME
034d1ce 
This change makes the API a little more user friendly - all request URIs with the path `/v1/res/` will be treated as the same URI with path `/v1/res`.
@liangdrew liangdrew merged commit 034d1ce into master May 11, 2018
@liangdrew liangdrew deleted the handler-fixme branch May 11, 2018 22:51
alex-aizman pushed a commit that referenced this pull request Mar 15, 2024
@gaikwadabhishek
dependabot: fix #15 and #16
c9d1fd3 
fix for https://github.com/NVIDIA/aistore/security/dependabot/15 and https://github.com/NVIDIA/aistore/security/dependabot/16

Signed-off-by: Abhishek Gaikwad <gaikwadabhishek1997@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@usmanong usmanong usmanong approved these changes

@VladimirMarkelov VladimirMarkelov VladimirMarkelov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liangdrew @usmanong @VladimirMarkelov