Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding DCO contributor signoff to CONTRIBUTING.md files #65

Open
jstjohn opened this issue Aug 1, 2024 · 0 comments
Open

Adding DCO contributor signoff to CONTRIBUTING.md files #65

jstjohn opened this issue Aug 1, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@jstjohn
Copy link
Collaborator

jstjohn commented Aug 1, 2024

Describe the bug

Our CONTRIBUTING.md files in both main and v2-main need to have DCO contribution sign-off.

  1. Enable rules to check that commits are signed.
  2. Add a section like the following: https://github.com/NVIDIA/TensorRT/blob/main/CONTRIBUTING.md#signing-your-work

For NVIDIA employees, see https://nvbugspro.nvidia.com/bug/4764170
@jstjohn jstjohn added the bug Something isn't working label Aug 1, 2024
jstjohn added a commit that referenced this issue Aug 2, 2024
@jstjohn
Adding license, and contributing guidelines from #72 and #65
64bbe05 
Signed-off-by: John St John <jstjohn@nvidia.com>
@jstjohn jstjohn mentioned this issue Aug 2, 2024
Merged
jstjohn added a commit that referenced this issue Aug 7, 2024
@jstjohn
Adding license, and contributing guidelines from #72 and #65 (#74)
6a7271d 
* Adding license, and contributing guidelines from #72 and #65

Signed-off-by: John St John <jstjohn@nvidia.com>

* Moving redundant PR suggestion block under another one

Signed-off-by: John St John <jstjohn@nvidia.com>

* Addressing PR comments

Signed-off-by: John St John <jstjohn@nvidia.com>

* Fix whitespace in contributing

---------

Signed-off-by: John St John <jstjohn@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jstjohn