-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pstjohn/stop and go test non validation #476
Merged
pstjohn
merged 9 commits into
NVIDIA:main
from
pstjohn:pstjohn/stop-and-go-test-non-validation
Dec 4, 2024
Merged
Pstjohn/stop and go test non validation #476
pstjohn
merged 9 commits into
NVIDIA:main
from
pstjohn:pstjohn/stop-and-go-test-non-validation
Dec 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstjohn
force-pushed
the
pstjohn/stop-and-go-test-non-validation
branch
3 times, most recently
from
December 2, 2024 22:44
c5deefd
to
bbf2bd7
Compare
pstjohn
requested review from
dorotat-nv,
farhadrgh,
jstjohn,
malcolmgreaves and
skothenhill-nv
as code owners
December 2, 2024 22:44
/build-ci |
jstjohn
approved these changes
Dec 3, 2024
jstjohn
reviewed
Dec 3, 2024
sichu2023
reviewed
Dec 3, 2024
sub-packages/bionemo-testing/src/bionemo/testing/harnesses/stop_and_go.py
Show resolved
Hide resolved
sichu2023
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go. Only some comments to help me understand it better.
pstjohn
force-pushed
the
pstjohn/stop-and-go-test-non-validation
branch
from
December 4, 2024 16:05
e8e4853
to
364659c
Compare
pstjohn
force-pushed
the
pstjohn/stop-and-go-test-non-validation
branch
from
December 4, 2024 16:59
364659c
to
117e00c
Compare
/build-ci |
/build-ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly test that train inputs and outputs are consistent when we use PreemptionCallback to handle a training interrupt.
Currently it seems that doing this changes the validation step schedule, but otherwise training should be identical.
STOP OUTPUT:
RESUME OUTPUT:
CONTINUOUS OUTPUT: