Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xFail known bad tests on H100 and fix CVEs #547

Merged
merged 4 commits into from
Dec 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Dockerfile.arm
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,7 @@ COPY --from=rust-env /usr/local/rustup /usr/local/rustup


# RUN rm -rf /usr/local/cargo /usr/local/rustup
RUN rm -rf /root/.cache/bazel
RUN chmod 777 -R /workspace/bionemo2/

# Transformer engine attention defaults
Expand Down
2 changes: 2 additions & 0 deletions docs/docs/user-guide/appendix/releasenotes-fw.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@
* Moved inference script to a new executable `infer_esm2`, and deprecated the inference example in the fine-tuning tutorial.
* Added new Jupyter notebook tutorials for inference and zero-shot protein design. These notebooks can be deployed on the cloud resources as a [brev.dev](https://www.brev.dev/) launchable.

### Known Issues:
* Loading a checkpoint for Geneformer inference on H100 has a known regression in accuracy. Work is in progress to resolve by next release.

## BioNeMo Framework v2.1

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,9 @@ def __getitem__(self, idx):
return {"text": self.input_ids[idx], "attention_mask": self.mask[idx]}


@pytest.mark.xfail(
reason="Known issue on H100 GPUs"
)
def test_geneformer_nemo1_v_nemo2_inference_golden_values(
geneformer_config: GeneformerConfig, cells: List[List[str]], seed: int = 42
):
Expand Down