Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add temporary mistune pin to fix docs build issue #559

Merged
merged 2 commits into from
Dec 30, 2024

Conversation

pstjohn
Copy link
Collaborator

@pstjohn pstjohn commented Dec 30, 2024

Pins mistune to fix a jupyter notebook build issue introduced in 3.1.0

lepture/mistune#403

@pstjohn pstjohn added the SKIP_CI Completely skips the CI pipeline label Dec 30, 2024
@pstjohn
Copy link
Collaborator Author

pstjohn commented Dec 30, 2024

/build-ci

@trvachov
Copy link
Collaborator

Approving bypass of review, because it's the holidays and this is currently breaking CI.

This PR just pins the version of a docs build dependency .. it seems pretty benign. I'll add post-hoc review of this PR as a JIRA: https://jirasw.nvidia.com/browse/BIONEMO-484

@pstjohn pstjohn disabled auto-merge December 30, 2024 19:03
@pstjohn pstjohn merged commit 1cea4bb into NVIDIA:main Dec 30, 2024
3 checks passed
@pstjohn pstjohn deleted the pstjohn/pin-mistune branch December 30, 2024 19:03
nvdreidenbach pushed a commit to nvdreidenbach/bionemo-framework that referenced this pull request Jan 2, 2025
Pins mistune to fix a jupyter notebook build issue introduced in 3.1.0

lepture/mistune#403

Bypassing review rules to fix CI due to holiday OOO

Signed-off-by: Danny <dreidenbach@nvidia.com>
nvdreidenbach pushed a commit to nvdreidenbach/bionemo-framework that referenced this pull request Jan 2, 2025
Pins mistune to fix a jupyter notebook build issue introduced in 3.1.0

lepture/mistune#403

Bypassing review rules to fix CI due to holiday OOO

Signed-off-by: Danny <dreidenbach@nvidia.com>
nvdreidenbach pushed a commit to nvdreidenbach/bionemo-framework that referenced this pull request Jan 2, 2025
Pins mistune to fix a jupyter notebook build issue introduced in 3.1.0

lepture/mistune#403

Bypassing review rules to fix CI due to holiday OOO

Signed-off-by: Danny <dreidenbach@nvidia.com>
nvdreidenbach pushed a commit to nvdreidenbach/bionemo-framework that referenced this pull request Jan 2, 2025
Pins mistune to fix a jupyter notebook build issue introduced in 3.1.0

lepture/mistune#403

Bypassing review rules to fix CI due to holiday OOO

Signed-off-by: Danny <dreidenbach@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SKIP_CI Completely skips the CI pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants