Un-xfail geneformer on H100 test #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trvachov
requested review from
jstjohn,
malcolmgreaves and
skothenhill-nv
as code owners
|
/build-ci |
trvachov
force-pushed
the
trvachov/h100-xfail
branch
from
04bee78 to
d2d0dc3
Compare
|
/build-ci |
cspades
approved these changes
Dec 31, 2024
pstjohn
approved these changes
Jan 1, 2025
|
Bypassing codeowners because of the holidays and this is a trivial change. Note @pstjohn I don't know what DCO check is. |
nvdreidenbach
pushed a commit
to nvdreidenbach/bionemo-framework
that referenced
this pull request
Jan 2, 2025
## Summary Un-xfails a geneformer H100 test. ## Details After base image upgrade to pytorch fw 24.12 (NVIDIA#553) , H100 geneformer issue is fixed. ## Usage and Testing ```python pytest ./sub-packages/bionemo-geneformer/tests/bionemo/geneformer/test_model.py::test_geneformer_nemo1_v_nemo2_inference_golden_values ``` Signed-off-by: Danny <dreidenbach@nvidia.com>
nvdreidenbach
pushed a commit
to nvdreidenbach/bionemo-framework
that referenced
this pull request
Jan 2, 2025
## Summary Un-xfails a geneformer H100 test. ## Details After base image upgrade to pytorch fw 24.12 (NVIDIA#553) , H100 geneformer issue is fixed. ## Usage and Testing ```python pytest ./sub-packages/bionemo-geneformer/tests/bionemo/geneformer/test_model.py::test_geneformer_nemo1_v_nemo2_inference_golden_values ``` Signed-off-by: Danny <dreidenbach@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Un-xfails a geneformer H100 test.
Details
After base image upgrade to pytorch fw 24.12 (#553) , H100 geneformer issue is fixed.
Usage and Testing