Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add codecov badge #588

Merged
merged 2 commits into from
Jan 10, 2025
Merged

add codecov badge #588

merged 2 commits into from
Jan 10, 2025

Conversation

pstjohn
Copy link
Collaborator

@pstjohn pstjohn commented Jan 10, 2025

Adds a codecov badge to the README and removes a duplicate pre-commit workflow.

Because jobs can only depend on other jobs in the same workflow file (IIUC), we put the pre-commit workflow in the new azure CI definition. That way, the docker build and test steps only trigger if the pre-commit results pass

@pstjohn pstjohn added the SKIP_CI Completely skips the CI pipeline label Jan 10, 2025
@pstjohn
Copy link
Collaborator Author

pstjohn commented Jan 10, 2025

/build-ci

@pstjohn pstjohn enabled auto-merge (squash) January 10, 2025 02:17
Signed-off-by: Peter St. John <pstjohn@nvidia.com>
@github-actions github-actions bot removed the SKIP_CI Completely skips the CI pipeline label Jan 10, 2025
Signed-off-by: Peter St. John <pstjohn@nvidia.com>
@pstjohn pstjohn changed the title add codecov badge [skip ci] add codecov badge Jan 10, 2025
@pstjohn pstjohn added the SKIP_CI Completely skips the CI pipeline label Jan 10, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.73%. Comparing base (c691df2) to head (6d5fbae).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #588   +/-   ##
=======================================
  Coverage   87.73%   87.73%           
=======================================
  Files          89       89           
  Lines        5758     5758           
=======================================
  Hits         5052     5052           
  Misses        706      706           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot removed the SKIP_CI Completely skips the CI pipeline label Jan 10, 2025
@pstjohn pstjohn added the SKIP_CI Completely skips the CI pipeline label Jan 10, 2025
@pstjohn
Copy link
Collaborator Author

pstjohn commented Jan 10, 2025

/build-ci

@pstjohn pstjohn merged commit 20f4937 into main Jan 10, 2025
10 checks passed
@pstjohn pstjohn deleted the pstjohn-patch-2 branch January 10, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SKIP_CI Completely skips the CI pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants