Update MoCo notebooks #614
Merged
+108
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danny <dreidenbach@nvidia.com>
nvdreidenbach
added
the
INCLUDE_NOTEBOOKS_TESTS
nvdreidenbach
requested review from
DejunL,
dorotat-nv,
guoqing-zhou,
jstjohn,
malcolmgreaves and
pstjohn
as code owners
dorotat-nv
approved these changes
Jan 16, 2025
pstjohn
approved these changes
Jan 16, 2025
|
Yup, LGTM. |
Signed-off-by: Danny <dreidenbach@nvidia.com>
…ly in cond env and fw container Signed-off-by: Danny <dreidenbach@nvidia.com>
Signed-off-by: Danny <dreidenbach@nvidia.com>
jstjohn
approved these changes
Jan 17, 2025
Signed-off-by: Danny <dreidenbach@nvidia.com>
nvdreidenbach
force-pushed
the
dreidenbach/moco_update
branch
from
b7c7a8d to
a6ea390
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #614 +/- ##
==========================================
+ Coverage 86.61% 86.62% +0.01%
==========================================
Files 116 116
Lines 6953 6961 +8
==========================================
+ Hits 6022 6030 +8
Misses 931 931 ☔ View full report in Codecov by Sentry. |
sichu2023
pushed a commit
that referenced
this pull request
Jan 17, 2025
### Description Update notebooks to pass tests. ### Type of changes <!-- Mark the relevant option with an [x] --> - [x ] Bug fix (non-breaking change which fixes an issue) --------- Signed-off-by: Danny <dreidenbach@nvidia.com> Signed-off-by: sichu <sichu@nvidia.com>
polinabinder1
pushed a commit
that referenced
this pull request
Jan 22, 2025
### Description Update notebooks to pass tests. ### Type of changes <!-- Mark the relevant option with an [x] --> - [x ] Bug fix (non-breaking change which fixes an issue) --------- Signed-off-by: Danny <dreidenbach@nvidia.com> Signed-off-by: Polina Binder <pbinder@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update notebooks to pass tests.
Type of changes