Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Pydantic to verify Test schema #145

Merged
merged 71 commits into from
Sep 25, 2024
Merged

Introduce Pydantic to verify Test schema #145

merged 71 commits into from
Sep 25, 2024

Commits on Jul 11, 2024

  1. Use Pydantic as a schema validator for Tests

    @amaslenn
    amaslenn committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    651b456 View commit details
    Browse the repository at this point in the history

  2. Cleanup

    @amaslenn
    amaslenn committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    362ba9b View commit details
    Browse the repository at this point in the history

  3. Remove pprint

    @amaslenn
    amaslenn committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    54807c5 View commit details
    Browse the repository at this point in the history

  4. Make pyright happy

    @amaslenn
    amaslenn committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    daab5ab View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Merge branch 'main' into am/schema

    @amaslenn
    amaslenn committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    56cab57 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Cleanup and use Registry

    @amaslenn
    amaslenn committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    e5805c0 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into am/schema

    @amaslenn
    amaslenn committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    8a59902 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Merge branch 'main' into am/schema

    @amaslenn
    amaslenn committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    94703ae View commit details
    Browse the repository at this point in the history

  2. Format llama.toml

    @amaslenn
    amaslenn committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    13acc95 View commit details
    Browse the repository at this point in the history

  3. Fix header tests

    @amaslenn
    amaslenn committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    2c1b700 View commit details
    Browse the repository at this point in the history

  4. Update doc and exported symbols

    @amaslenn
    amaslenn committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    2fd8863 View commit details
    Browse the repository at this point in the history

  5. Remove needless method

    @amaslenn
    amaslenn committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    66e8397 View commit details
    Browse the repository at this point in the history

  6. Fix tests collection, make it stricter

    @amaslenn
    amaslenn committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    426c837 View commit details
    Browse the repository at this point in the history

  7. Make ruff happy

    @amaslenn
    amaslenn committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    240e839 View commit details
    Browse the repository at this point in the history

  8. Make extra_cmd_args a dict[str, str]

    @amaslenn
    amaslenn committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    ed3349e View commit details
    Browse the repository at this point in the history

  9. Add --mode verify-tests

    @amaslenn
    amaslenn committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    7cf1324 View commit details
    Browse the repository at this point in the history

  10. More tests

    @amaslenn
    amaslenn committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    2869598 View commit details
    Browse the repository at this point in the history

  11. Improve verify-tests mode

    @amaslenn
    amaslenn committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    75dac07 View commit details
    Browse the repository at this point in the history

  12. Fix a typo

    @amaslenn
    amaslenn committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    28294fb View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. Refactoring

    @amaslenn
    amaslenn committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    c8589a2 View commit details
    Browse the repository at this point in the history

  2. Add initial support for Grok and GPT 

    Verified on:
1. cloudaix/conf/devops/verification/test/fsdp-grok1proxy-16.toml
2. cloudaix/conf/devops/verification/test/sanity_gpt5b_1.toml
    @amaslenn
    amaslenn committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    8506441 View commit details
    Browse the repository at this point in the history

  3. Add pydantic to pyproject.toml's requirements

    @amaslenn
    amaslenn committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    b7f26f7 View commit details
    Browse the repository at this point in the history

  4. Re-org for test definitions

    @amaslenn
    amaslenn committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    b2e826e View commit details
    Browse the repository at this point in the history

  5. Small reorg in pyproject

    @amaslenn
    amaslenn committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    13ac594 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. Support for more configs

    @amaslenn
    amaslenn committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    edb0c73 View commit details
    Browse the repository at this point in the history

  2. Update definitions

    @amaslenn
    amaslenn committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    931970c View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into am/schema

    @amaslenn
    amaslenn committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    168ca54 View commit details
    Browse the repository at this point in the history

  4. Align NCCL extra args with existing implementation

    @amaslenn
    amaslenn committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    da22d24 View commit details
    Browse the repository at this point in the history

  5. Make pyright happy

    @amaslenn
    amaslenn committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    a1a34b2 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. Merge branch 'main' into am/schema

    @amaslenn
    amaslenn committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    96416c6 View commit details
    Browse the repository at this point in the history

  2. Fixes

    @amaslenn
    amaslenn committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    fc7a50d View commit details
    Browse the repository at this point in the history

  3. Refactor TestDefinitions into own modules

    @amaslenn
    amaslenn committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    6884279 View commit details
    Browse the repository at this point in the history

  4. Make ruff happy

    @amaslenn
    amaslenn committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    0a472bc View commit details
    Browse the repository at this point in the history

  5. Update lint-import rules

    @amaslenn
    amaslenn committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    d2fe3af View commit details
    Browse the repository at this point in the history

  6. Simplify test definitions

    @amaslenn
    amaslenn committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    43a9e18 View commit details
    Browse the repository at this point in the history

  7. Fix taplo formatting

    @amaslenn
    amaslenn committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    8f6bb07 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Merge branch 'main' into am/schema

    @amaslenn
    amaslenn committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    389757c View commit details
    Browse the repository at this point in the history

  2. Use format_validation_error() for formatting pydantic errors

    @amaslenn
    amaslenn committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    3d9fcb5 View commit details
    Browse the repository at this point in the history

  3. Make ruff happy

    @amaslenn
    amaslenn committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    cb1fe02 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Make docker_image_url a required argument in Test TOML for Chakra

    @amaslenn
    amaslenn committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    37127a0 View commit details
    Browse the repository at this point in the history

  2. Do not enforce limitations for NeMo test

    @amaslenn
    amaslenn committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    c1fc351 View commit details
    Browse the repository at this point in the history

  3. Simplify UCC definition, make ruff happy

    @amaslenn
    amaslenn committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    98e6cb7 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Update test definitions to work with external configs

    @amaslenn
    amaslenn committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    360a4dc View commit details
    Browse the repository at this point in the history

  2. Get rid of test template TOMLs

    @amaslenn
    amaslenn committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    ae2f517 View commit details
    Browse the repository at this point in the history

  3. Fixes

    @amaslenn
    amaslenn committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    909b363 View commit details
    Browse the repository at this point in the history

  4. Refactor tests for cmd_gen

    @amaslenn
    amaslenn committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    77c370f View commit details
    Browse the repository at this point in the history

  5. More fixes and tests for JaxToolbox-based tests

    @amaslenn
    amaslenn committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    19b5ef5 View commit details
    Browse the repository at this point in the history

  6. Fixed tests

    @amaslenn
    amaslenn committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    d54162f View commit details
    Browse the repository at this point in the history

  7. Updates and fixes

    @amaslenn
    amaslenn committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    ef8f3fa View commit details
    Browse the repository at this point in the history

  8. Make vulture happy

    @amaslenn
    amaslenn committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    a576f14 View commit details
    Browse the repository at this point in the history

  9. Update docs

    @amaslenn
    amaslenn committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    d49e519 View commit details
    Browse the repository at this point in the history

  10. Fix XLA flags formatting

    @amaslenn
    amaslenn committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    8950b82 View commit details
    Browse the repository at this point in the history

  11. Set default value for Grok.fdl_config

    @amaslenn
    amaslenn committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    564af34 View commit details
    Browse the repository at this point in the history

  12. Remove unused code

    @amaslenn
    amaslenn committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    8516dc2 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Make xla boolean values lowcase

    @amaslenn
    amaslenn committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    b65cb85 View commit details
    Browse the repository at this point in the history

  2. Fix tests

    @amaslenn
    amaslenn committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    e047ace View commit details
    Browse the repository at this point in the history

  3. Add --mode verify-tests example

    @amaslenn
    amaslenn committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    dbdf4ac View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Merge branch 'main' into am/schema

    @amaslenn
    amaslenn committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    bfcaf6b View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. More alignments with original code

    @amaslenn
    amaslenn committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    7587937 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Remove Jax and related test definitions

    @amaslenn
    amaslenn committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    8877f54 View commit details
    Browse the repository at this point in the history

  2. Update USER_GUIDE.md on test template vs test, etc.

    @amaslenn
    amaslenn committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    693ca32 View commit details
    Browse the repository at this point in the history

  3. Improve UI when there are parsing issues in Test configs

    @amaslenn
    amaslenn committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    57ee40f View commit details
    Browse the repository at this point in the history

  4. Fix imports

    @amaslenn
    amaslenn committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    938df4e View commit details
    Browse the repository at this point in the history

  5. Revert accidential change

    @amaslenn
    amaslenn committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    b547094 View commit details
    Browse the repository at this point in the history

  6. Path absolute path + bug fix for pre_test and load container flags

    @srivatsankrishnan
    srivatsankrishnan committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    0513ba9 View commit details
    Browse the repository at this point in the history

  7. fix pre_test flag

    @srivatsankrishnan
    srivatsankrishnan committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    4dda839 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. revert changes

    @srivatsankrishnan
    srivatsankrishnan committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    7611288 View commit details
    Browse the repository at this point in the history

  2. ruff fixes

    @srivatsankrishnan
    srivatsankrishnan committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    1fe9311 View commit details
    Browse the repository at this point in the history

  3. more ruff fixes

    @srivatsankrishnan
    srivatsankrishnan committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    5594cf2 View commit details
    Browse the repository at this point in the history

  4. Use load_container directly

    @amaslenn
    amaslenn committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    a3e6d27 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into am/schema

    @TaekyungHeo
    TaekyungHeo authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    7dcf8a7 View commit details
    Browse the repository at this point in the history