-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pydantic for Test Scenario #205
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaslenn
requested review from
TaekyungHeo,
srivatsankrishnan and
srinivas212
September 26, 2024 14:50
We should also have a corresponding PR in CloudAIX. The CloudAIX TOML files and code should be updated accordingly. |
TaekyungHeo
reviewed
Sep 26, 2024
srivatsankrishnan
previously approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
TaekyungHeo
previously approved these changes
Oct 7, 2024
amaslenn
dismissed stale reviews from TaekyungHeo and srivatsankrishnan
via
October 7, 2024 16:39
a33c825
TaekyungHeo
approved these changes
Oct 7, 2024
srivatsankrishnan
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduce Pydantic schema validation for Test Scenarios.
Test Plan
Additional Notes
—
Highlights for Release notes
We are working on schema improvements to simplify configs management and make them verifiable. This will help ensure that configs are correct before expensive runs on real hardware. Today we are enabling it for Test Scenario configs. This is a continuation of #145.
Tests
becomes and array. This helps making case names more expressive:before:
id
field is mandatory and must be unique and is used to specify dependencies:name
(under the list of tests) renamed totest_name
to better reflect its meaning. It still references a test defined in a separate TOML file.before