Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Sleep to ensure implementation consistency #234

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Update Sleep to ensure implementation consistency #234

merged 1 commit into from
Oct 7, 2024

Conversation

TaekyungHeo
Copy link
Member

@TaekyungHeo TaekyungHeo commented Oct 7, 2024 •
edited
Loading

Summary

srun commands are generated by generate_srun_command, which internally calls generate_srun_prefix and generate_test_command. Therefore, unless a test template requires something specific, any test template should update generate_test_command by default, not generate_srun_command.

Test Plan

CI passes

@TaekyungHeo TaekyungHeo added the enhancement New feature or request label Oct 7, 2024
@TaekyungHeo TaekyungHeo marked this pull request as ready for review October 7, 2024 19:11
@TaekyungHeo TaekyungHeo added the Oct24 Oct'24 release feature label Oct 7, 2024
@srinivas212 srinivas212 merged commit ead4bbc into NVIDIA:main Oct 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srinivas212 srinivas212 srinivas212 approved these changes

@amaslenn amaslenn Awaiting requested review from amaslenn

@artemry-nv artemry-nv Awaiting requested review from artemry-nv

@srivatsankrishnan srivatsankrishnan Awaiting requested review from srivatsankrishnan

Assignees
No one assigned
Labels
enhancement New feature or request Oct24 Oct'24 release feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TaekyungHeo @srinivas212