Rename test definitions #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TaekyungHeo
requested review from
amaslenn,
artemry-nv,
srivatsankrishnan and
srinivas212
TaekyungHeo
added
enhancement
amaslenn
reviewed
Oct 8, 2024
There was a problem hiding this comment.
I agree with Chakra change, but UCCCmdArgs -> UCCTestCmdArgs seems unreasonable. It is also longer now. And following this logic, UCCTestDefinition should become UCCTestTestDefinition now.
P.S. all our "tests" are better described as "workloads" IMO:
UCCTestDefinition->UCCWorkloadTestScenario->Suite.Testsinside scenario ->Cases.- etc.
|
@srinivas212 & @srivatsankrishnan, please review our discussion. Let's talk about this later. I incorporated @amaslenn's comments and reverted the changes to the UCC and NCCL test names. Let's merge what we've already agreed on first. |
amaslenn
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Naming conventions in CloudAI are not accurate. UCC and NCCL are libraries, while UCC tests and NCCL tests are what we are running in CloudAI. Chakra is a project that includes Chakra replay as a tool.
Test Plan
CI passes