Make TestDefinition a part of Test #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TaekyungHeo
requested review from
TaekyungHeo,
artemry-nv,
srivatsankrishnan and
srinivas212
TaekyungHeo
added
enhancement
|
@amaslenn, Could you briefly describe the intention of this PR in the PR summary section? |
TaekyungHeo
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make
TestDefinitiona part ofTest. This is needed to simplify Tempates and Strategies usage: by passing TestRun object we will be passing and actualTestDefinionobject with all cmd args as typed object, no acmd_argsdictionary.Test Plan
CI
Additional Notes
—