Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename TestRun-related var and method in src/cloudai/_core/test_scenario_parser.py #292

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Rename TestRun-related var and method in src/cloudai/_core/test_scenario_parser.py #292

merged 1 commit into from
Oct 29, 2024

Conversation

TaekyungHeo
Copy link
Member

@TaekyungHeo TaekyungHeo commented Oct 29, 2024 •
edited
Loading

Summary

  • Rename testruns_by_id to test_runs_by_id
  • Rename _create_section_test_run to _create_test_run. The concept of "section test" is deprecated and has been replaced by "test run". There is no concept of a "section test run".

Test Plan

CI passes

@TaekyungHeo TaekyungHeo added enhancement New feature or request Jan25 Jan'25 release feature labels Oct 29, 2024
@TaekyungHeo TaekyungHeo merged commit cb153f5 into NVIDIA:main Oct 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amaslenn amaslenn amaslenn approved these changes

@srivatsankrishnan srivatsankrishnan Awaiting requested review from srivatsankrishnan

@srinivas212 srinivas212 Awaiting requested review from srinivas212

@artemry-nv artemry-nv Awaiting requested review from artemry-nv

Assignees
No one assigned
Labels
enhancement New feature or request Jan25 Jan'25 release feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TaekyungHeo @amaslenn