Generic Slurm Container job #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaslenn
requested review from
srivatsankrishnan,
srinivas212 and
TaekyungHeo
TaekyungHeo
added
enhancement
TaekyungHeo
approved these changes
Nov 13, 2024
src/cloudai/schema/test_template/slurm_container/report_generation_strategy.py
Show resolved
Hide resolved
TaekyungHeo
approved these changes
Nov 18, 2024
srivatsankrishnan
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
As discussed in the call, this makes sense for the VFM use case currently we have. We cannot use existing Nemo since VFM uses Nemo 2.0. This can be generic and currently the PR has two repos and hashes. These fields can be made optional to make it truly generic. Future PR will address this.
Also the report generation logic also needs to be updated accordingly to make it truly generic. But for this VFM use case, this makes sense as agreed in the call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduce a new workload type: GenericSlurmContainer.
Test Plan
CI
Additional Notes
—