Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Chakra replay to use tdef #306

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Update Chakra replay to use tdef #306

merged 2 commits into from
Nov 20, 2024

Conversation

TaekyungHeo
Copy link
Member

@TaekyungHeo TaekyungHeo commented Nov 20, 2024 •
edited
Loading

Summary

There are two issues with the current Chakra replay implementation:

  1. It does not utilize tdef's Docker image path. Consequently, it may generate an sbatch script as shown below, even though we have the cached Docker image locally.
  2. It does not utilize Pydantic models.

Test Plan

  1. CI passes
  2. Ran on a server

@TaekyungHeo TaekyungHeo added bug Something isn't working enhancement New feature or request Jan25 Jan'25 release feature labels Nov 20, 2024
@TaekyungHeo TaekyungHeo marked this pull request as ready for review November 20, 2024 18:40
@srinivas212 srinivas212 merged commit 21e5717 into NVIDIA:main Nov 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srinivas212 srinivas212 srinivas212 approved these changes

@amaslenn amaslenn Awaiting requested review from amaslenn

@artemry-nv artemry-nv Awaiting requested review from artemry-nv

@srivatsankrishnan srivatsankrishnan Awaiting requested review from srivatsankrishnan

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request Jan25 Jan'25 release feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TaekyungHeo @srinivas212