Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SystemObjectUpdater functionality #36

Merged
merged 1 commit into from
May 28, 2024
Merged

Remove SystemObjectUpdater functionality #36

merged 1 commit into from
May 28, 2024

Conversation

amaslenn
Copy link
Contributor

Summary

Removed SystemObjectUpdater functionality to simplify the design. update() is part of System object now.

Test Plan

CI

Additional Notes

—

@amaslenn
Remove SystemObjectUpdater functionality
c885d2d 
To simplify the design, it is part of `System` now.
TaekyungHeo
TaekyungHeo approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@TaekyungHeo TaekyungHeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This was one of my TODOs. I appreciate it.

@TaekyungHeo TaekyungHeo merged commit b440433 into main May 28, 2024
2 checks passed
@amaslenn amaslenn deleted the no-updater branch May 28, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TaekyungHeo TaekyungHeo TaekyungHeo approved these changes

@srinivas212 srinivas212 Awaiting requested review from srinivas212

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amaslenn @TaekyungHeo