Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reinstate stdout assertions and add more tests #25

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Reinstate stdout assertions and add more tests #25

merged 1 commit into from
Apr 13, 2022

Conversation

jacobtomlinson
Copy link
Member

  • Ensure Bubble Tea stdout uses Cobra stdout to allow better mocking.
  • Reinstate stdout assertions that were removed in Refactor validator into Bubble Tea TUI app #21.
  • Added a broken Kubeflow container example.
  • Added a test to check the broken container fails.
  • Updated the example doc with new stdout.

@jacobtomlinson
Reinstate stdout assertions and add more tests
cf426d7 
Signed-off-by: Jacob Tomlinson <jtomlinson@nvidia.com>
@jacobtomlinson jacobtomlinson added documentation Improvements or additions to documentation enhancement New feature or request labels Apr 13, 2022
@jacobtomlinson jacobtomlinson enabled auto-merge (squash) April 13, 2022 10:06
@jacobtomlinson jacobtomlinson merged commit 1f9c78f into NVIDIA:main Apr 13, 2022
@jacobtomlinson jacobtomlinson deleted the improve-testing branch April 13, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jacobtomlinson