Skip to content
This repository has been archived by the owner on Feb 4, 2022. It is now read-only.

Inspect containerd version and switch config version accordingly #2

Closed
wants to merge 1 commit into from

Conversation

shysank
Copy link
Contributor

@shysank shysank commented Feb 17, 2021

This pr inspects containerd version and switches b/w v1 and v2 config spec accordingly. Fixes #143

@cloud-native-bot
Copy link

Hello There!

Thanks for your contribution!
This repository is a read-only mirror of the following repository: https://gitlab.com/nvidia/container-toolkit/container-config

Do you mind:

Thanks again!

@shysank
Copy link
Contributor Author

shysank commented Feb 17, 2021

Lots of vendor files added because I've added containerd as a dependency to query for the version. We can avoid by using ctr version to inspect version. However, this means we have an added dependency on ctr to be present in the node, and the tests were failing too. Happy to switch it to ctr version if we're okay with it. wdyt?

/cc @klueska

@shysank
Copy link
Contributor Author

shysank commented Feb 17, 2021

Logs from testing:

time="2021-02-17T17:34:38Z" level=info msg="Setting up runtime"
time="2021-02-17T17:34:38Z" level=info msg="Starting 'setup' for containerd"
time="2021-02-17T17:34:38Z" level=info msg="Parsing arguments: [/usr/local/nvidia/toolkit]"
time="2021-02-17T17:34:38Z" level=info msg="Successfully parsed arguments"
time="2021-02-17T17:34:38Z" level=info msg="Loading config: //run/docker/containerd/containerd.toml"
time="2021-02-17T17:34:38Z" level=info msg="Successfully loaded config"
time="2021-02-17T17:34:38Z" level=info msg="version not present in config"
time="2021-02-17T17:34:38Z" level=info msg="containerd version is v1.3.9"
time="2021-02-17T17:34:38Z" level=info msg="Updating config"
time="2021-02-17T17:34:38Z" level=info msg="Updating V2 config"
time="2021-02-17T17:34:38Z" level=info msg="Successfully updated config"
time="2021-02-17T17:34:38Z" level=info msg="Flushing config"
time="2021-02-17T17:34:38Z" level=info msg="Successfully flushed config"
time="2021-02-17T17:34:38Z" level=info msg="Sending SIGHUP signal to containerd"
time="2021-02-17T17:34:38Z" level=info msg="Successfully signaled containerd"
time="2021-02-17T17:34:38Z" level=info msg="Completed 'setup' for containerd"
time="2021-02-17T17:34:38Z" level=info msg="Shutting Down"
time="2021-02-17T17:34:38Z" level=info msg="Completed nvidia-toolkit"

@klueska
Copy link
Contributor

klueska commented Feb 17, 2021

As the comment above suggests, we do development on gitlab, not github. Please open an MR there.

@shysank
Copy link
Contributor Author

shysank commented Feb 17, 2021

@shysank shysank closed this Feb 17, 2021
@shysank shysank deleted the fix_config_spec_version branch February 17, 2021 18:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nvidia-device-plugin-daemonset toolkit validation fails with containerd
2 participants