This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Fixes Issues #161 and #162 #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I ran into these issues while adding tests for DeviceSpmv. Looks like this PR was accidentally closed during the repo reorg last year. Reopening. |
alliepiper
approved these changes
Jul 30, 2021
alliepiper
reviewed
Jul 30, 2021
| @@ -664,12 +664,12 @@ struct DispatchSpmv | |||
|
|
|||
| // Get grid dimensions | |||
| dim3 spmv_grid_size( | |||
| CUB_MIN(num_merge_tiles, max_dim_x), | |||
| CUB_MIN(num_merge_tiles, static_cast<unsigned int>(max_dim_x)), | |||
There was a problem hiding this comment.
These were fixed earlier by b2e64cf. I'll drop this while rebasing.
…f a memory block from a pool allocator is passed)
alliepiper
force-pushed
the
bug_ext_memory_pool
branch
from
3749499
to
01980f9
Compare
alliepiper
added a commit
to alliepiper/thrust
that referenced
this pull request
Jul 30, 2021
|
DVS CL: 30244015 |
alliepiper
added
testing: gpuCI in progress
alliepiper
added a commit
to alliepiper/cub
that referenced
this pull request
Jul 30, 2021
alliepiper
added
testing: gpuCI passed
|
Looks good -- thanks for the patch, sorry it took so long to merge it! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #161 Close #162