Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Merge sort docs and casts #363

Merged
merged 4 commits into from
Oct 15, 2021
Merged

Merge sort docs and casts #363

merged 4 commits into from
Oct 15, 2021

Conversation

gevtushenko
Copy link
Collaborator

This PR contains:

  1. Documentation refactoring
  2. Types clarifications
  3. Direct usage of CUB_NS_QUALIFIER in the merge sort dispatch mechanism

@gevtushenko gevtushenko force-pushed the main-bug/github/merge_sort_docs_and_casts branch 2 times, most recently from aafd744 to 145776f Compare August 28, 2021 23:48
@zasdfgbnm zasdfgbnm mentioned this pull request Sep 8, 2021
Closed
@gevtushenko gevtushenko force-pushed the main-bug/github/merge_sort_docs_and_casts branch from 145776f to d6e81a2 Compare September 9, 2021 08:26
@alliepiper alliepiper self-assigned this Sep 21, 2021
@alliepiper alliepiper added this to the 1.15.0 milestone Sep 21, 2021
alliepiper
alliepiper suggested changes Sep 21, 2021
View reviewed changes
cub/device/device_merge_sort.cuh Outdated Show resolved Hide resolved
cub/device/device_merge_sort.cuh Outdated Show resolved Hide resolved
cub/device/device_merge_sort.cuh Outdated Show resolved Hide resolved
cub/device/device_merge_sort.cuh Show resolved Hide resolved
cub/device/device_merge_sort.cuh Show resolved Hide resolved
cub/device/device_merge_sort.cuh Outdated Show resolved Hide resolved
cub/device/dispatch/dispatch_merge_sort.cuh Show resolved Hide resolved
cub/device/dispatch/dispatch_merge_sort.cuh Outdated Show resolved Hide resolved
cub/device/dispatch/dispatch_merge_sort.cuh Outdated Show resolved Hide resolved
cub/device/dispatch/dispatch_merge_sort.cuh Outdated Show resolved Hide resolved
@alliepiper alliepiper assigned gevtushenko and unassigned alliepiper Sep 21, 2021
@alliepiper alliepiper added the P1: should have Necessary, but not critical. label Sep 21, 2021
@alliepiper alliepiper assigned alliepiper and unassigned gevtushenko Sep 23, 2021
@gevtushenko gevtushenko force-pushed the main-bug/github/merge_sort_docs_and_casts branch from dc746e1 to 2d6e6b4 Compare October 3, 2021 14:27
alliepiper
alliepiper approved these changes Oct 13, 2021
View reviewed changes
Copy link
Collaborator

@alliepiper alliepiper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- Make sure you've run tests on gpuCI before merging.

gevtushenko added a commit to gevtushenko/thrust that referenced this pull request Oct 14, 2021
@gevtushenko
Testing NVIDIA/cub/pull/363. Do not merge.
79056a0
@gevtushenko gevtushenko force-pushed the main-bug/github/merge_sort_docs_and_casts branch from 2d6e6b4 to c351b0f Compare October 14, 2021 13:40
gevtushenko added a commit to gevtushenko/thrust that referenced this pull request Oct 14, 2021
@gevtushenko
Testing NVIDIA/cub/pull/363. Do not merge.
76e4626
@alliepiper alliepiper added the testing: gpuCI in progress Started gpuCI testing. label Oct 14, 2021
@alliepiper alliepiper assigned gevtushenko and unassigned alliepiper Oct 14, 2021
@gevtushenko gevtushenko added testing: gpuCI passed Passed gpuCI testing. and removed testing: gpuCI in progress Started gpuCI testing. labels Oct 15, 2021
@gevtushenko gevtushenko merged commit 241fb21 into NVIDIA:main Oct 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zasdfgbnm zasdfgbnm zasdfgbnm left review comments

@alliepiper alliepiper alliepiper approved these changes

Assignees

@gevtushenko gevtushenko

Labels
P1: should have Necessary, but not critical. testing: gpuCI passed Passed gpuCI testing.
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@gevtushenko @alliepiper @zasdfgbnm