Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Fix half conversions #395

Merged
merged 1 commit into from
Oct 27, 2021
Merged

Fix half conversions #395

merged 1 commit into from
Oct 27, 2021

Conversation

zasdfgbnm
Copy link
Contributor

@zasdfgbnm zasdfgbnm commented Oct 26, 2021 •
edited
Loading

Fixes: #394

@zasdfgbnm
Copy link
Contributor Author

@allisonvacanti cub 1.15 is not finally released yet, is that correct? If so, can we integrate this last-minute fix to 1.15? I really want PyTorch to compile with every version of cub.

@zasdfgbnm
Copy link
Contributor Author

cc: @senior-zero

@zasdfgbnm
Copy link
Contributor Author

cc: @ptrblck

@gevtushenko gevtushenko self-requested a review October 26, 2021 16:34
gevtushenko
gevtushenko approved these changes Oct 26, 2021
View reviewed changes
Copy link
Collaborator

@gevtushenko gevtushenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this! I thought that __CUDA_NO_HALF_CONVERSIONS__ meant that there are no conversion intrinsics.

@gevtushenko gevtushenko added testing: gpuCI in progress Started gpuCI testing. testing: internal ci in progress Currently testing on internal NVIDIA CI (DVS). labels Oct 26, 2021
@alliepiper
Copy link
Collaborator

@zasdfgbnm I can backport this to 1.15 for the release. I'll do another RC today or tomorrow with a few other small bug fixes that have popped up.

@senior-zero Once the tests look good, let's land this in main and I'll cherry pick it over to 1.15.X when I make the new RC.

@zasdfgbnm
Copy link
Contributor Author

Thanks a lot!

@alliepiper alliepiper added this to the 1.15.0 milestone Oct 26, 2021
@alliepiper
Copy link
Collaborator

DVS CL: 30579794
gpuCI: NVIDIA/thrust#1553

@alliepiper alliepiper added helps: pytorch Helps or needed by PyTorch. P1: should have Necessary, but not critical. testing: internal ci passed Passed internal NVIDIA CI (DVS). and removed testing: internal ci in progress Currently testing on internal NVIDIA CI (DVS). labels Oct 26, 2021
@gevtushenko gevtushenko added testing: gpuCI passed Passed gpuCI testing. and removed testing: gpuCI in progress Started gpuCI testing. labels Oct 27, 2021
@gevtushenko gevtushenko merged commit 819ef12 into NVIDIA:main Oct 27, 2021
@zasdfgbnm zasdfgbnm deleted the fix-half branch October 27, 2021 13:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gevtushenko gevtushenko gevtushenko approved these changes

Assignees
No one assigned
Labels
helps: pytorch Helps or needed by PyTorch. P1: should have Necessary, but not critical. testing: gpuCI passed Passed gpuCI testing. testing: internal ci passed Passed internal NVIDIA CI (DVS).
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.

Unable to build with -D__CUDA_NO_HALF_CONVERSIONS__
3 participants
@zasdfgbnm @alliepiper @gevtushenko