This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Support reduction for more than 2^31 items #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaatish
approved these changes
Nov 2, 2022
gevtushenko
force-pushed
the
enh-main/github/reduce_with_more_than_2_32_items
branch
from
1790296
to
6153c10
Compare
|
Because |
gevtushenko
force-pushed
the
enh-main/github/reduce_with_more_than_2_32_items
branch
from
6153c10
to
5c64430
Compare
gevtushenko
added a commit
to gevtushenko/thrust
that referenced
this pull request
Nov 13, 2022
gevtushenko
force-pushed
the
enh-main/github/reduce_with_more_than_2_32_items
branch
from
5c64430
to
8b9f0b0
Compare
gevtushenko
added a commit
to gevtushenko/thrust
that referenced
this pull request
Nov 13, 2022
|
Hi @senior-zero, glad to see this patch landed! Would it be backported to the 1.17.x branch? |
|
Hello @leofang! I completely forgot to reply about backporting this PR. Sorry about that! I wouldn't like to backport this. Is there something stopping you from using the newer version of CUB. Please let us know if we can help switch to a more recent version of CUB or fix potential issues. |
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partially addresses the following issue. Supporting larger offsets for
ArgMinandArgMaxwould have to wait, since it's a bit more involving. There also could be a bit better testing, but it might wait till Catch2 rewrite.The main purpose of this PR is to unblock original issue by providing an example of what we expect from such a change. The main direction of this modification can be found here.