This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gevtushenko
added
testing: gpuCI passed
Passed gpuCI testing.
and removed
testing: gpuCI in progress
Started gpuCI testing.
labels
Jan 3, 2023
miscco
approved these changes
Jan 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is awesome, thanks a lot. I assume that int128
implicitly requires uint128
which has the same switch?
elstehle
approved these changes
Jan 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, looks solid!
canonizer
suggested changes
Jan 5, 2023
gevtushenko
added a commit
to gevtushenko/thrust
that referenced
this pull request
Jan 6, 2023
canonizer
approved these changes
Jan 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, provided that the comments are addressed.
gevtushenko
force-pushed
the
enh-main/github/sort_128
branch
from
January 7, 2023 10:53
56cad37
to
475f96f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supports
__int128_t
and__uint128_t
in block/device radix sort as well as block radix rank. It's partially answering the question on 128 bit types support. Performance wise,__int128_t
utilize BW similarly to 64 bit types.