Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[custom op] Single qubit operation synthesis #2154

Merged
merged 22 commits into from
Sep 11, 2024
Merged

[custom op] Single qubit operation synthesis #2154

merged 22 commits into from
Sep 11, 2024

Conversation

khalatepradnya
Copy link
Collaborator

Towards: #1475

Synthesize single qubit custom operations using Euler angle decomposition

@khalatepradnya khalatepradnya self-assigned this Aug 26, 2024
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Aug 27, 2024
@cuda-quantum-bot
Docs preview for PR #2154.
7659b6b
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Aug 27, 2024
@cuda-quantum-bot
Docs preview for PR #2154.
b52a25f
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Aug 27, 2024
@cuda-quantum-bot
Docs preview for PR #2154.
c6fd0bd
@khalatepradnya khalatepradnya added enhancement New feature or request ecosystem labels Aug 28, 2024
@khalatepradnya khalatepradnya force-pushed the one-qubit-synthesis branch 2 times, most recently from 7c1db26 to 82267ea Compare August 29, 2024 23:03
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Aug 30, 2024
@cuda-quantum-bot
Docs preview for PR #2154.
7f45656
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Aug 30, 2024
@cuda-quantum-bot
Docs preview for PR #2154.
f0125c5
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Aug 30, 2024
@cuda-quantum-bot
Docs preview for PR #2154.
b52bd66
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 2, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Sep 2, 2024
@cuda-quantum-bot
Docs preview for PR #2154.
7971cfd
@khalatepradnya khalatepradnya force-pushed the one-qubit-synthesis branch 3 times, most recently from 7559ff9 to 8eda189 Compare September 3, 2024 20:41
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Sep 3, 2024
@cuda-quantum-bot
Docs preview for PR #2154.
079c8ce
github-actions bot pushed a commit that referenced this pull request Sep 10, 2024
@cuda-quantum-bot
Docs preview for PR #2154.
4a6506b
@khalatepradnya
* <--- CI Debugging --->
9e807f4 
Is the new PhotonicsKernel source of issue?
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Sep 10, 2024
@cuda-quantum-bot
Docs preview for PR #2154.
3bacdf4
github-actions bot pushed a commit that referenced this pull request Sep 10, 2024
@cuda-quantum-bot
Docs preview for PR #2154.
7498558
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

@khalatepradnya
* <--- CI Debugging --->
5976f84 
Skip python/tests/remote/test_remote_platform.py::test_observe
github-actions bot pushed a commit that referenced this pull request Sep 10, 2024
@cuda-quantum-bot
Docs preview for PR #2154.
562eeda
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

@khalatepradnya khalatepradnya mentioned this pull request Sep 10, 2024
Closed
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Sep 10, 2024
@cuda-quantum-bot
Docs preview for PR #2154.
2325d0d
schweitzpgi
schweitzpgi reviewed Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@schweitzpgi schweitzpgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good. Thanks for the nice work. Some minor comments.

include/cudaq/Optimizer/Builder/Factory.h Outdated Show resolved Hide resolved
lib/Optimizer/Transforms/UnitarySynthesis.cpp Show resolved Hide resolved
@khalatepradnya
* Addressing review comments
a063083 
  -- Move the responsibility to emit errors to codegen pass
  -- Remove unnecessary blank line
schweitzpgi
schweitzpgi approved these changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@schweitzpgi schweitzpgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Pradnya.

@khalatepradnya khalatepradnya enabled auto-merge (squash) September 11, 2024 18:11
github-actions bot pushed a commit that referenced this pull request Sep 11, 2024
@cuda-quantum-bot
Docs preview for PR #2154.
576bdbf
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

@khalatepradnya khalatepradnya merged commit 7e675ad into NVIDIA:main Sep 11, 2024
129 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2024
@khalatepradnya khalatepradnya deleted the one-qubit-synthesis branch September 11, 2024 20:27
@khalatepradnya khalatepradnya linked an issue Oct 1, 2024 that may be closed by this pull request
[RFC] Unitary Synthesis #1475
Open
12 tasks
@bettinaheim bettinaheim added no release notes Don't list this PR in the release notes and removed enhancement New feature or request labels Nov 19, 2024
@bettinaheim bettinaheim added this to the release 0.9.0 milestone Nov 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@1tnguyen 1tnguyen 1tnguyen left review comments

@schweitzpgi schweitzpgi schweitzpgi approved these changes

@boschmitt boschmitt Awaiting requested review from boschmitt

@bmhowe23 bmhowe23 Awaiting requested review from bmhowe23

@annagrin annagrin Awaiting requested review from annagrin

@anthony-santana anthony-santana Awaiting requested review from anthony-santana

@amccaskey amccaskey Awaiting requested review from amccaskey

Assignees

@khalatepradnya khalatepradnya

Labels
ecosystem no release notes Don't list this PR in the release notes
Projects
None yet
Milestone
release 0.9.0
Development

Successfully merging this pull request may close these issues.

[RFC] Unitary Synthesis
4 participants
@khalatepradnya @schweitzpgi @1tnguyen @bettinaheim