Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix signed int overflow in uccsd #64

Merged
merged 3 commits into from
Feb 2, 2025
Merged

Conversation

annagrin
Copy link
Collaborator

Fix some issues to allow compilation of uccsd

  • Fix signed int overflow in uccsd
  • allow specifying shots in vqe

Towards: NVIDIA/cuda-quantum#2357

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
Copy link
Collaborator

@amccaskey amccaskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@annagrin annagrin merged commit d8498bd into NVIDIA:main Feb 2, 2025
14 checks passed
kvmto pushed a commit to kvmto/cudaqx that referenced this pull request Feb 3, 2025
### Fix some issues to allow compilation of `uccsd`

- Fix signed int overflow in `uccsd`
- allow specifying shots in `vqe`

Towards: NVIDIA/cuda-quantum#2357

---------

Signed-off-by: Anna Gringauze <agringauze@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants