fix(eqos): Use correct TX clock name #76
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EqosDeviceDxe would fail to set the TX clock rate with the following output: PhyLinkAdjustEmacConfig: Failed to set clock frequency Not Found This prevented the network from working at 100Base-T or 10Base-T. (Tested on Xavier NX devkit). The clock name used in the device tree from NVIDIA's sources is "eqos_tx". Signed-off-by: Daniel Fullmer <dfullmer@anduril.com>
|
The suggested change makes it specific to Eqos and removes support for other hardware. |
|
To clarify we will work on an updated patch and post it that handles both cases (as we have some device trees on platforms with different names) Thank you for pointing this out. |
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EqosDeviceDxe would fail to set the TX clock rate with the following output:
This prevented the network from working at 100Base-T or 10Base-T. (Tested on Xavier NX devkit). The clock name used in the device tree from NVIDIA's sources is "eqos_tx".
Signed-off-by: Daniel Fullmer dfullmer@anduril.com