Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

egl-wayland: Fix use after free at library teardown #151

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

Molytho
Copy link
Contributor

@Molytho Molytho commented Oct 13, 2024

This patch extends the hack described here to wlEglDestroyFeedback which might destroy a zwp_linux_dmabuf_feedback_v1 object.

I encountered a segmentation fault at termination of the game celeste because of this

src/wayland-egldisplay.c Outdated Show resolved Hide resolved
src/wayland-egldisplay.c Outdated Show resolved Hide resolved
@amshafer
Copy link
Collaborator

++@dkorkmazturk to take a look at this as well

@dkorkmazturk
Copy link
Collaborator

Looks good to me. Thank you for fixing this issue.

Copy link
Collaborator

@amshafer amshafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please rebase this to pick up the CI that was recently added?

@amshafer amshafer merged commit 0cd471d into NVIDIA:master Oct 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants