Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set generator _call_model() and _generate() type hints; amend functions #694

Merged
merged 5 commits into from
May 24, 2024
Merged

Set generator _call_model() and _generate() type hints; amend functions #694

merged 5 commits into from
May 24, 2024

Conversation

leondz
Copy link
Collaborator

@leondz leondz commented May 23, 2024

No description provided.

@leondz leondz added the generators Interfaces with LLMs label May 23, 2024
@leondz leondz requested a review from jmartin-tech May 23, 2024 11:12
@leondz leondz linked an issue May 23, 2024 that may be closed by this pull request
remove generations count param from generator constructors #656
Open
3 tasks
jmartin-tech
jmartin-tech reviewed May 23, 2024
View reviewed changes
Copy link
Collaborator

@jmartin-tech jmartin-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Goal of this PR is consistency, I made a couple comments in that vein.

garak/generators/huggingface.py Outdated Show resolved Hide resolved
garak/generators/nvcf.py Outdated Show resolved Hide resolved
garak/generators/nim.py Show resolved Hide resolved
leondz and others added 2 commits May 23, 2024 17:16
@leondz @jmartin-tech
add generations_this_call in garak.generators.huggingface.generate
c800307 
Co-authored-by: Jeffrey Martin <jemartin@nvidia.com>
Signed-off-by: Leon Derczynski <leonderczynski@gmail.com>
@leondz
catch nvcf blank prompt more closely; improve typing.List use consist…
28997b1 
…ency
@leondz leondz merged commit d417303 into main May 24, 2024
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 24, 2024
@leondz leondz deleted the bugfix/generators_return_list branch May 29, 2024 07:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jmartin-tech jmartin-tech jmartin-tech left review comments

Assignees
No one assigned
Labels
generators Interfaces with LLMs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove generations count param from generator constructors
2 participants
@leondz @jmartin-tech